Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix detection of cross_prefix argument #613

Merged
merged 1 commit into from
Jan 4, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/lib/mlkem_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def do_no_opt(self):
return self.args.opt.lower() in ["all", "no_opt"]

def compile_mode(self):
return "Cross" if self.args.cross_prefix is not None else "Native"
return "Cross" if self.args.cross_prefix != "" else "Native"

def _compile_schemes(self, test_type, opt):
"""compile or cross compile with some extra environment variables and makefile arguments"""
Expand All @@ -84,7 +84,7 @@ def _compile_schemes(self, test_type, opt):
env_update = {}
if self.args.cflags is not None and self.args.cflags != "":
env_update["CFLAGS"] = self.args.cflags
if self.args.cross_prefix is not None and self.args.cross_prefix != "":
if self.args.cross_prefix != "":
env_update["CROSS_PREFIX"] = self.args.cross_prefix

env = os.environ.copy()
Expand Down
Loading