CI: Add Docker-based compatibility tests #563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the test scripts compatible with Python 3.8.
- It removes all typing annotations, adding some additional
commentary instead.
- It removes the | operator for dictionaries
- It removes `match` on enums
- It removes `removeprefix()`
It also notes and fixes some problematic uses of objects
(specifically `{}` and `[]`) being used for default-values;
`None` is used instead and the intended default values installed
at the beginning of the function.
Signed-off-by: Hanno Becker <[email protected]>
This enables the use of the `functest` action outside of the nix shell, where `./scripts` and `./scripts/ci` may not be in the PATH. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
This commit makes the use of `sudo` optional in the `setup-ubuntu` action. This is to make it suitable for running on Ubuntu Docker images, which do not come with `sudo` by default. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
Some compilers don't seem to like it. Signed-off-by: Hanno Becker <[email protected]>
Signed-off-by: Hanno Becker <[email protected]>
This commit extends the CI to run compatibility tests for Docker images - ubuntu-22.04:gcc-12x - ubuntu-22.04:gcc-11x - ubuntu-20.04:gcc-8x - ubuntu-20.04:gcc-7x - ubuntu-20.04:clang-9x - ubuntu-20.04:clang-8x - ubuntu-20.04:clang-7x-bm-framework - ubuntu-20.04:clang-7x - ubuntu-20.04:clang-10x - ubuntu-22.04:base Those images are pre-built on a custom EC2 AMI, and match the images used in the AWS-LC CI. Signed-off-by: Hanno Becker <[email protected]>
mkannwischer
commented
Dec 21, 2024
| # such as lto. Using gcc-ar is preferred when creating or linking static libraries | ||
| # if the binary is compiled with -flto. However, it is not universally present, so | ||
| # only use it if available. | ||
| CC_AR ?= $(if $(shell which gcc-ar),gcc-ar,ar) |
There was a problem hiding this comment.
Doesn't this break if you are using Darwin with gcc-ar installed, but you compile with clang?
I'm not very sure about this.
There was a problem hiding this comment.
I tried to fix this by looking at cc --version to see if it's clang or not, and if it's gcc, check for gcc-ar.
Closed
|
Included in #562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Docker-based compatibility tests for various Ubuntu-20 and Ubuntu-22 docker images; so far, AArch64 only.
A number of changes had to be made, esp. to the test scripts; see commits.
Fix #560
(Hoisted out from #562)