Fix macOS build of benchmark test with GCC 14 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables -Wpedantic in hal/hal.c where the result of calling dlsym() needs to be converted from "void *" to the appropriate function-pointer type, which normally generates a warning or error with GCC 14. Signed-off-by: Rod Chapman <[email protected]>
hanno-becker
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
Disables -Wpedantic in hal/hal.c where the result of calling dlsym() needs to be converted from "void *" to the appropriate function-pointer type, which normally generates a warning or error with GCC 14.
All tests pass
"tests bench -r -c M1" now works on macOS with GCC 14.2.0
lint passes
No expected performance impact