Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unused buflen in gen_matrix_entry #551

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

bhess
Copy link
Contributor

@bhess bhess commented Dec 19, 2024

Summary:
Fixes unused buflen variable in gen_matrix_entry. Detected when importing the code to liboqs and running a build with scan_build.

Performed local tests:

  • lint passing (not sure how to run this locally.)
  • tests all passing
  • tests bench passing
  • tests cbmc passing (I might be missing some dependencies to run this.)

Do you expect this change to impact performance: No

If yes, please provide local benchmarking results.

@bhess bhess requested a review from a team as a code owner December 19, 2024 16:23
Copy link
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanno-becker
Copy link
Contributor

hanno-becker commented Dec 19, 2024

tests cbmc passing (I might be missing some dependencies to run this.)

@bhess The easiest way (and indeed really easy) is to use nix (setting the CBMC toolchain up yourself isn't much fun). Have you tried? See https://github.com/pq-code-package/mlkem-native/blob/main/BUILDING.md#nix-setup

lint passing (not sure how to run this locally.)

Assuming you installed nix and entered the shell with nix develop --experimental-features 'nix-command flakes' (which for the first time only will take you maybe ~10min, henceforth seconds), it should just be lint

@hanno-becker
Copy link
Contributor

Full CI passed.

@hanno-becker hanno-becker merged commit 7f321d9 into pq-code-package:main Dec 19, 2024
71 checks passed
@bhess
Copy link
Contributor Author

bhess commented Dec 19, 2024

tests cbmc passing (I might be missing some dependencies to run this.)

@bhess The easiest way (and indeed really easy) is to use nix (setting the CBMC toolchain up yourself isn't much fun). Have you tried? See https://github.com/pq-code-package/mlkem-native/blob/main/BUILDING.md#nix-setup

lint passing (not sure how to run this locally.)

Assuming you installed nix and entered the shell with nix develop --experimental-features 'nix-command flakes' (which for the first time only will take you maybe ~10min, henceforth seconds), it should just be lint

Thanks for the hint using nix! I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants