Fix python files detection in format and lint scripts #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, the --include scripts/tests option was used with the Python formatter black because scripts/tests was the only Python script. However, this flag overrides the default file detection pattern, meaning only scripts/tests was being formatted. As more .py files have been added, this setup became insufficient. This commit updates the regex to include both scripts/tests and all .py files, ensuring proper detection and formatting of all Python scripts in the repository. Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
potsrevennil
force-pushed
the
fix-py-lint
branch
from
5219ca4 to
372e74a
Compare
mkannwischer
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the black Python formatter configuration to correctly detect and format all Python files. Initially, --include scripts/tests was used, which only targeted the scripts/tests file. As more .py files were added, this setup no longer covered the entire project. The regex has been updated to include all .py files, ensuring proper formatting for all Python scripts while preserving the default file detection pattern.
Performed local tests:
lintpassingtests allpassingtests benchpassingtests cbmcpassingDo you expect this change to impact performance: Yes/No
If yes, please provide local benchmarking results.