CI: Add test for non-standard values of GEN_MATRIX_NBLOCKS #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
gen_nmatrix_blocks_test
branch
4 times, most recently
from
5f57c42 to
244f947
Compare
hanno-becker
force-pushed
the
gen_nmatrix_blocks_test
branch
from
244f947 to
9bd1bcb
Compare
mkannwischer
approved these changes
Nov 19, 2024
hanno-becker
force-pushed
the
gen_nmatrix_blocks_test
branch
from
9bd1bcb to
2d5f4a8
Compare
GEN_MATRIX_NBLOCKS is a heuristic value estimating the amount of rejection sampling input to sample 256 polynomial coefficients. While this value is hardcoded to 3 by default, one should be able to set it to any positive value. Moreover, some code-paths are not as easily reached with the default value, and testing a lower value increases the chances of catching bugs in those. This commit allows the user to specify GEN_MATRIX_NBLOCKS in the CFLAGS, and extends the CI to test the non-standard values 1,2, and 4. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
gen_nmatrix_blocks_test
branch
from
2d5f4a8 to
a75a08b
Compare
Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
gen_nmatrix_blocks_test
branch
from
a75a08b to
46f496f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEN_MATRIX_NBLOCKS is a heuristic value estimating the amount of rejection sampling input to sample 256 polynomial coefficients.
While this value is hardcoded to 3 by default, one should be able to set it to any positive value. Moreover, some code-paths are not as easily reached with the default value, and testing a lower value increases the chances of catching bugs in those.
This commit allows the user to specify GEN_MATRIX_NBLOCKS in the CFLAGS, and extends the CI to test the non-standard values 1,2, and 4.