Improve speed of proof of matvec_mul() #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust modelling of arrays in CBMC for proof of this function, as recommended by CBMC team (CBMC Issue 8505). Signed-off-by: Rod Chapman <[email protected]>
hanno-becker
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Those are impressive gains, @rod-chapman. Can you leave a comment in matvec_mul/Makefile with a vague description of what is happening, and open an issue so we don't forget to incorporate this into the proof guide once we have a better understanding of those options?
The explanatory text is adapted from that appearing in CBMC Issue 8505. Signed-off-by: Rod Chapman <[email protected]>
|
Comment added to Makefile |
hanno-becker
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust modelling of arrays in CBMC for proof of this function, as recommended by CBMC team (See CBMC Issue 8505).
Proof for this function reduces from 70 seconds to about 9 seconds on desktop.
All tests OK
All proofs OK
lint OK