Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUMMY: Test EC2 CI (2) #394

Closed
wants to merge 1 commit into from
Closed

DUMMY: Test EC2 CI (2) #394

wants to merge 1 commit into from

Conversation

mkannwischer
Copy link
Contributor

@mkannwischer mkannwischer commented Nov 13, 2024

No description provided.

I suspect that our CI failures may be due to the runner
registration failing due to the name already being used.
By default, it is using the hostname as the Github runner
name which defaults to the private IP address on EC2
instances. When instances get terminated, it does not
delete the runners in Github which means we now have
a lot of offline runners listed.

This may be explaining why our CI sometimes timesouts
due to the runner not being registered.

I patched ec2-github-runner to add the `--replace` flag
when registering the runner.

Signed-off-by: Matthias J. Kannwischer <[email protected]>
@mkannwischer mkannwischer added DO-NOT-MERGE benchmark this PR should be benchmarked in CI labels Nov 13, 2024
@mkannwischer mkannwischer deleted the dummy2 branch November 14, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI DO-NOT-MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant