Fix EC2 failures when Github runner name is already taken #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn - it still happens |
mkannwischer
added
benchmark
mkannwischer
force-pushed
the
fix-ec2-ci
branch
from
fd3f315 to
25cb656
Compare
mkannwischer
added
benchmark
mkannwischer
force-pushed
the
fix-ec2-ci
branch
from
25cb656 to
3ea1adc
Compare
mkannwischer
added
benchmark
mkannwischer
force-pushed
the
fix-ec2-ci
branch
from
3ea1adc to
76b9d85
Compare
|
After running this a few times, the only failures I am seeing now are related to the vCPU limit. I had only once failure that was not related to that and I cannot explain that one. |
I suspect that our CI failures may be due to the runner registration failing due to the name already being used. By default, it is using the hostname as the Github runner name which defaults to the private IP address on EC2 instances. When instances get terminated, it does not delete the runners in Github which means we now have a lot of offline runners listed. This may be explaining why our CI sometimes timesouts due to the runner not being registered. I patched ec2-github-runner to add the `--replace` flag when registering the runner. Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker
force-pushed
the
fix-ec2-ci
branch
from
76b9d85 to
9990d83
Compare
hanno-becker
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thank you @mkannwischer for investigating. Let's merge this and monitor if it helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that our CI failures may be due to the runner registration failing due to the name already being used. By default, it is using the hostname as the Github runner name which defaults to the private IP address on EC2 instances. When instances get terminated, it does not delete the runners in Github which means we now have a lot of offline runners listed.
This may be explaining why our CI sometimes timesouts due to the runner not being registered.
I patched ec2-github-runner to add the
--replaceflag when registering the runner:mkannwischer/ec2-github-runner@d15c880
Fixes #391.