Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axiomatize FIPS-202 Hash functions #385

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Axiomatize FIPS-202 Hash functions #385

merged 1 commit into from
Nov 13, 2024

Conversation

rod-chapman
Copy link
Contributor

This PR adds CBMC contracts to the FIPS202 hash functions and their MLKEM-specific variants.

We also adjust indcpa_keypair_derand() to avoid explicit aliasing of actual parameters in the call to hash_g(), as is already done in AWS-LC.

All tests OK
All proofs OK
lint OK

mlkem/indcpa.c Outdated Show resolved Hide resolved
@rod-chapman
Copy link
Contributor Author

Squashed and pushed.

This PR adds CBMC contracts to the FIPS202 hash functions
and their MLKEM specific variants.

We also adjust indcpa_keypair_derand() to avoid
explicit aliasing of actual parameters in the call
to hash_g(), as is already done in AWS-LC.

Signed-off-by: Rod Chapman <[email protected]>
Copy link
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @rod-chapman

@hanno-becker hanno-becker merged commit f5929ab into main Nov 13, 2024
33 checks passed
@hanno-becker hanno-becker deleted the axiomatize_hash branch November 13, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants