Improve speed of polyvec_add() proof. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rod-chapman
force-pushed
the
speedup_polyvec_add_proof
branch
from
c1419ba to
27d5a17
Compare
hanno-becker
force-pushed
the
speedup_polyvec_add_proof
branch
from
27d5a17 to
c1f4db1
Compare
|
@rod-chapman Something is off here. Sometimes the CI succeeds, but just now I stopped it after 5h of spinning. |
hanno-becker
force-pushed
the
speedup_polyvec_add_proof
branch
3 times, most recently
from
0bfeffd to
b53f1f0
Compare
hanno-becker
approved these changes
Nov 12, 2024
hanno-becker
force-pushed
the
speedup_polyvec_add_proof
branch
from
b53f1f0 to
053a09f
Compare
Removes detailed ENSURES clause for polyvec_add() since this is not required for proof of type-safety of calling units. Add comment explaining why a strong ENSURES clause on polyvec_add() is NOT required for proof of type-safety. Signed-off-by: Rod Chapman <[email protected]>
hanno-becker
force-pushed
the
speedup_polyvec_add_proof
branch
from
053a09f to
6b80fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
Removes detailed ENSURES clause for polyvec_add()
since this is not required for proof of type-safety of calling units.
Proof time improves from 11minutes to 1 minute on MacBook Pro using Z3.
Tried Bitwuzla but was slower.
All tests OK
lint OK