Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address + UB sanitizer to CI debug tests #279

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add address + UB sanitizer to CI debug tests #279

merged 1 commit into from
Oct 30, 2024

Conversation

hanno-becker
Copy link
Contributor

@hanno-becker hanno-becker commented Oct 30, 2024

This PR extends the native debug tests in the CI to enable the address and undefined-behaviour sanitizers in GCC.

Based on #277

Fixes https://github.com/pq-code-package/mlkem-c-aarch64/issues/278

@hanno-becker hanno-becker force-pushed the ubsan branch 4 times, most recently from d948f60 to 1a31aec Compare October 30, 2024 07:00
@hanno-becker hanno-becker force-pushed the ubsan branch 2 times, most recently from 15441c4 to 21bdc37 Compare October 30, 2024 09:16
@hanno-becker hanno-becker added the benchmark this PR should be benchmarked in CI label Oct 30, 2024
This commit extends the native debug tests in the CI to enable
the address and undefined-behaviour sanitizers in GCC.

Signed-off-by: Hanno Becker <[email protected]>
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Oct 30, 2024
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@hanno-becker hanno-becker merged commit e6360ce into main Oct 30, 2024
84 checks passed
@hanno-becker hanno-becker deleted the ubsan branch October 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add address and UB sanitizer to debug tests
2 participants