Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused XKCP symbols #269

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove unused XKCP symbols #269

merged 1 commit into from
Oct 29, 2024

Conversation

mkannwischer
Copy link
Contributor

Depends on #266 #267.

KeccakP-1600-times4-SIMD256.c is copied from XKCP and contains a lot of symbols that we are not actually using.
This commit trims it down to just KeccakP1600times4_PermuteAll_24rounds.

KeccakP-1600-times4-SIMD256.c is copied from XKCP and contains
a lot of symbols that we are not actually using.
This commit trims it down to just KeccakP1600times4_PermuteAll_24rounds.

Signed-off-by: Matthias J. Kannwischer <[email protected]>
@hanno-becker hanno-becker added the benchmark this PR should be benchmarked in CI label Oct 29, 2024
Copy link
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanno-becker hanno-becker merged commit 059c93d into main Oct 29, 2024
84 checks passed
@hanno-becker hanno-becker deleted the removeturboshake branch October 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants