Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant of "Nix cache enhancement in CI and ping clang-tools version to 17.0.6 " #253

Closed
wants to merge 6 commits into from

Conversation

hanno-becker
Copy link
Contributor

This is an almost-copy of #233 removing the commit on propagation of GH access tokens which I don't yet understand and would like to discuss further merging. Opening this version to check whether the performance gains are still similarly pronounced, in which case this version can move forward and propagations of tokens follows in due cause.

nixos 24.05 channel is updated to the latest commit a3f9ad65a0bf298ed5847629a57808b97e6e8077 as well

Signed-off-by: Thing-han, Lim <[email protected]>
Now the shell becomes
- default, ci-linter: same as before, not changed
- ci: native shell
- ci-cross: shell equipped with both native and cross compiled gcc and glibc (would be slow on the first build)
- ci-cbmc: native shell with cbmc
- ci-cbmc-cross: ci-cross shell with cbmc

Signed-off-by: Thing-han, Lim <[email protected]>
…stem configuration

- Linux runner with root user: install with single-user mode
- Linux runner with non-root user or macOS runner: install with multi-user mode

Signed-off-by: Thing-han, Lim <[email protected]>
magic-nix-cache runs into GH rate limit easily, and ec2 instance somehow
cannot restore magic-nix-cache.

cache-nix-action would save a whole nix shell in GH cache, which can be
sharable between branches, thus speeding up CI.

Hash of nix files is used as cache suffix, so that cache sharing between
branch should be safe

'-multi' suffix for cache prefix is added if installed in multi-user
mode, to avoid cache pollution

Signed-off-by: Thing-han, Lim <[email protected]>
Disable linting for ec2_all as it doesn't add much value when there's
already an linting job on GH shared x86_64 runner

Run linting first for all ec2 if linting is enabled

Use ubuntu-latest instead of pqcp-x64 for matrix, since once the matrix
is all excluded (when pushed to fork), the following jobs that depends
on this won't be executed

Signed-off-by: Thing-han, Lim <[email protected]>
@hanno-becker hanno-becker added the benchmark this PR should be benchmarked in CI label Oct 17, 2024
@mkannwischer mkannwischer deleted the pin-clang-format-version_alt branch December 4, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants