Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nix installer cache issue #138

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Fix nix installer cache issue #138

merged 4 commits into from
Sep 19, 2024

Conversation

potsrevennil
Copy link
Contributor

@potsrevennil potsrevennil commented Sep 18, 2024

There is a cache issue in the Nix installer action, and since we don't really need to cache the nix installer, and there is no config for turning this off, I figured it'd be better to simply install the nix installer manually.

@potsrevennil potsrevennil added the benchmark this PR should be benchmarked in CI label Sep 18, 2024
@potsrevennil potsrevennil force-pushed the fix-nix-cache branch 6 times, most recently from e094e53 to 00b2cfe Compare September 18, 2024 08:12
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil potsrevennil force-pushed the fix-nix-cache branch 2 times, most recently from 14c6343 to 00b2cfe Compare September 18, 2024 10:33
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 18, 2024
@potsrevennil
Copy link
Contributor Author

Somehow, for our rpi4/rpi5 self-hosted runners, nix is pre-installed, but it cannot be found github default shell.
If I uninstalled nix, then the workflow will pass on the first try, then fail on the second.

Which means the startup files of teh default github shell didn't set the PATH variable correctly. (But I cannot wrap my head out which startup file I should modify...)

If I tryied to source /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh, then rpi4 can read the PATH properly, but rpi5 still couldn't...

Fortunately workaround by referencing nix via its absolute path can solve the issue

@potsrevennil
Copy link
Contributor Author

Then there's still some weird error happening

Magic cache will sometimes encounter this retry timeout error (setting continue-on-error for this step can avoid the jobs failed at least)
https://github.com/pq-code-package/mlkem-c-aarch64/actions/runs/10926593405/job/30330814152

Then this is the weirdest error...
on macOS shared runner, when installing nix-installer, it said that there's already pre-exists configuration ...
Only encounter this error once, still need to keep an eye on this issue though...
https://github.com/potsrevennil/mlkem-c-aarch64/actions/runs/10926439327/job/30330297755

@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 19, 2024
@potsrevennil potsrevennil marked this pull request as ready for review September 19, 2024 06:19
@potsrevennil potsrevennil requested a review from a team September 19, 2024 06:19
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 19, 2024
@hanno-becker hanno-becker merged commit d83f17d into main Sep 19, 2024
29 checks passed
@hanno-becker hanno-becker deleted the fix-nix-cache branch September 19, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants