Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist CI components into reusable actions and workflows #122

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Hoist CI components into reusable actions and workflows #122

merged 7 commits into from
Sep 11, 2024

Conversation

hanno-becker
Copy link
Contributor

@hanno-becker hanno-becker commented Sep 10, 2024 •
edited
Loading

No description provided.

@hanno-becker hanno-becker requested a review from a team September 10, 2024 20:07
@hanno-becker hanno-becker force-pushed the ci_work branch 3 times, most recently from 892564a to d6ccc55 Compare September 11, 2024 03:19
@hanno-becker hanno-becker added the benchmark this PR should be benchmarked in CI label Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 2 times, most recently from 832c034 to daac370 Compare September 11, 2024 03:49
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 8 times, most recently from 3ddcf1a to ecccd5e Compare September 11, 2024 06:35
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 2 times, most recently from 088353d to f3a248e Compare September 11, 2024 06:39
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker removed the benchmark this PR should be benchmarked in CI label Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 2 times, most recently from b69078f to f2d0634 Compare September 11, 2024 07:18
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 2 times, most recently from 9e76b64 to fd31b31 Compare September 11, 2024 07:30
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker hanno-becker force-pushed the ci_work branch 2 times, most recently from 0f3d171 to 726f062 Compare September 11, 2024 07:38
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
@hanno-becker
Reduce nix output
3a6211f 
Signed-off-by: Hanno Becker <[email protected]>
potsrevennil
potsrevennil reviewed Sep 11, 2024
View reviewed changes
.github/actions/functest/action.yml Show resolved Hide resolved
.github/actions/functest/action.yml Show resolved Hide resolved
.github/actions/functest/action.yml Show resolved Hide resolved
.github/actions/cbmc/action.yml Outdated Show resolved Hide resolved
potsrevennil
potsrevennil reviewed Sep 11, 2024
View reviewed changes
.github/actions/bench/action.yml Outdated Show resolved Hide resolved
.github/actions/functest/action.yml Outdated Show resolved Hide resolved
@hanno-becker
Address review feedback
cb9c354 
Signed-off-by: Hanno Becker <[email protected]>
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 11, 2024
potsrevennil
potsrevennil approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@potsrevennil potsrevennil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now! After reducing all the boilerplat, I'm happy with the structure now. Thanks for the work!

@hanno-becker hanno-becker merged commit e3d21eb into main Sep 11, 2024
20 checks passed
@hanno-becker hanno-becker deleted the ci_work branch September 11, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potsrevennil potsrevennil potsrevennil approved these changes

Assignees
No one assigned
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanno-becker @potsrevennil