-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic ntt #109
Basic ntt #109
Conversation
I would like the configuration of OPT to be as simple as possible. As a user, I don't want to pass a complicated argument as NTT123_4567, but just say whether ASM should be enabled or not. Internally, or for more experienced users, we can also expose a fine-grained option, but I think this should be secondary. Even when OPT is set, the AArch64 ASM should only be used when we are actually running on an AArch64 system. There should be a system header detecting this once and for all, exporting something like USE_AARCH64_ASM as the combination of running on an AArch64 system and OPT being set. Then, the actual source should cleanly rely on that flag only. For benchmarking, I would suggest that we set OPT=1 by default, and add new -ref benchmarks which force OPT=0 and thereby fall-back to the reference implementation. @mkannwischer You may want to chime in here. |
af3096f
to
807cf4e
Compare
c062ced
to
d170147
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Use OPT=AARCH64 at the toplevel to enable AArch64 optimizations. Refined (internal) configuration options, e.g. for switching between NTT implementations, to follow. Signed-off-by: Hanno Becker <[email protected]>
78d4b6a
to
f694d02
Compare
See slothy-optimizer/slothy#84 Signed-off-by: Hanno Becker <[email protected]>
deddf53
to
33eb2db
Compare
33eb2db
to
d8f01f2
Compare
Signed-off-by: Hanno Becker <[email protected]>
d8f01f2
to
bf70a1b
Compare
1f279fa
to
bf70a1b
Compare
Signed-off-by: Thing-han, Lim <[email protected]>
Moving #98 to main repo to enable benchmarking workflow.