-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Build System for Easier Extensibility and Future Optimizations #100
Merged
hanno-becker
merged 9 commits into
pq-code-package:main
from
potsrevennil:refactor-build-system
Sep 8, 2024
Merged
Refactor Build System for Easier Extensibility and Future Optimizations #100
hanno-becker
merged 9 commits into
pq-code-package:main
from
potsrevennil:refactor-build-system
Sep 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
potsrevennil
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 4, 2024
hanno-becker
reviewed
Sep 5, 2024
potsrevennil
force-pushed
the
refactor-build-system
branch
from
September 5, 2024 05:58
bd5b0b8
to
5222b2f
Compare
potsrevennil
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 5, 2024
hanno-becker
force-pushed
the
refactor-build-system
branch
from
September 5, 2024 09:53
a17467b
to
47e26bc
Compare
hanno-becker
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 5, 2024
potsrevennil
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 5, 2024
hanno-becker
force-pushed
the
refactor-build-system
branch
from
September 5, 2024 10:21
47e26bc
to
debb81c
Compare
hanno-becker
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 5, 2024
ryjones
force-pushed
the
refactor-build-system
branch
from
September 6, 2024 13:49
debb81c
to
d3eb1d0
Compare
ryjones
added
benchmark
this PR should be benchmarked in CI
and removed
benchmark
this PR should be benchmarked in CI
labels
Sep 6, 2024
@hanno-becker the reason the EC2 benchmarks don't run is this is a PR from an external repo, without access to tokens. |
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
Signed-off-by: Thing-han, Lim <[email protected]>
hanno-becker
force-pushed
the
refactor-build-system
branch
from
September 8, 2024 04:43
d3eb1d0
to
96febc3
Compare
hanno-becker
approved these changes
Sep 8, 2024
hanno-becker
pushed a commit
that referenced
this pull request
Sep 8, 2024
…ns (#100) * place all artifacts under test/build dir Signed-off-by: Thing-han, Lim <[email protected]> * refactor the build system Signed-off-by: Thing-han, Lim <[email protected]> * refactor build system objs macro Signed-off-by: Thing-han, Lim <[email protected]> * make don't print directory Signed-off-by: Thing-han, Lim <[email protected]> * integrate the new build system to python script Signed-off-by: Thing-han, Lim <[email protected]> * format nix file Signed-off-by: Thing-han, Lim <[email protected]> * fix arch flags not correctly set Signed-off-by: Thing-han, Lim <[email protected]> * ci fix -static to be cflags Signed-off-by: Thing-han, Lim <[email protected]> * fix static compilation for benchmarking on a55 Signed-off-by: Thing-han, Lim <[email protected]> --------- Signed-off-by: Thing-han, Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors the build system to improve extensibility, preparing for #98.
Build artifacts are now placed under a configurable directory which is default to
test/build