Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Build System for Easier Extensibility and Future Optimizations #100

Merged

Conversation

potsrevennil
Copy link
Contributor

The PR refactors the build system to improve extensibility, preparing for #98.

Build artifacts are now placed under a configurable directory which is default to test/build

@potsrevennil potsrevennil mentioned this pull request Sep 4, 2024
@potsrevennil potsrevennil marked this pull request as ready for review September 4, 2024 10:41
@potsrevennil potsrevennil requested a review from a team September 4, 2024 10:41
@hanno-becker hanno-becker added the benchmark this PR should be benchmarked in CI label Sep 4, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 4, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 5, 2024
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 5, 2024
@potsrevennil potsrevennil added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 5, 2024
@hanno-becker hanno-becker added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 5, 2024
@ryjones ryjones force-pushed the refactor-build-system branch from debb81c to d3eb1d0 Compare September 6, 2024 13:49
@ryjones ryjones added benchmark this PR should be benchmarked in CI and removed benchmark this PR should be benchmarked in CI labels Sep 6, 2024
@ryjones
Copy link
Contributor

ryjones commented Sep 6, 2024

@hanno-becker the reason the EC2 benchmarks don't run is this is a PR from an external repo, without access to tokens.

@hanno-becker hanno-becker merged commit b9e7133 into pq-code-package:main Sep 8, 2024
7 checks passed
hanno-becker pushed a commit that referenced this pull request Sep 8, 2024
…ns (#100)

* place all artifacts under test/build dir

Signed-off-by: Thing-han, Lim <[email protected]>

* refactor the build system

Signed-off-by: Thing-han, Lim <[email protected]>

* refactor build system objs macro

Signed-off-by: Thing-han, Lim <[email protected]>

* make don't print directory

Signed-off-by: Thing-han, Lim <[email protected]>

* integrate the new build system to python script

Signed-off-by: Thing-han, Lim <[email protected]>

* format nix file

Signed-off-by: Thing-han, Lim <[email protected]>

* fix arch flags not correctly set

Signed-off-by: Thing-han, Lim <[email protected]>

* ci fix -static to be cflags

Signed-off-by: Thing-han, Lim <[email protected]>

* fix static compilation for benchmarking on a55

Signed-off-by: Thing-han, Lim <[email protected]>

---------

Signed-off-by: Thing-han, Lim <[email protected]>
@potsrevennil potsrevennil deleted the refactor-build-system branch September 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark this PR should be benchmarked in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants