Disambiguate opt vs non-opt in benchmarking stats (#126)

* Disambiguate opt vs non-opt in benchmarking stats Signed-off-by: Hanno Becker <[email protected]> * Compactify bench_ec2_all.yml Signed-off-by: Hanno Becker <[email protected]> * Only store optimized benchmark results Signed-off-by: Hanno Becker <[email protected]> --------- Signed-off-by: Hanno Becker <[email protected]>
pq-code-package · Sep 13, 2024 · ec360c3 · ec360c3
1 parent ad617bf
commit ec360c3
Showing 1 changed file with 19 additions and 32 deletions.
diff --git a/.github/workflows/bench_ec2_all.yml b/.github/workflows/bench_ec2_all.yml
@@ -9,8 +9,8 @@ on:
     branches: ["main"]
     types: [ "labeled" ]
 jobs:
-  bench-gv2:
-    name: Graviton2 ${{ matrix.opt.name }}
+  bench:
+    name: ${{ matrix.target.name }} ${{ matrix.opt.name }}
     permissions:
       contents: 'read'
       id-token: 'write'
@@ -22,38 +22,25 @@ jobs:
             value: true
           - name: non-opt
             value: false
+        target:
+          - name: Graviton2
+            ec2_instance_type: t4g.small
+            ec2_ami: ubuntu-latest (aarch64)
+            archflags: -mcpu=cortex-a76 -march=armv8.2-a
+            cflags: -DFORCE_AARCH64
+          - name: Graviton3
+            ec2_instance_type: c7g.medium
+            ec2_ami: ubuntu-latest (aarch64)
+            archflags: -mcpu=neoverse-v1 -march=armv8.4-a
+            cflags: -DFORCE_AARCH64
     uses: ./.github/workflows/bench_ec2_reusable.yml
     if: github.repository_owner == 'pq-code-package' && (github.event.label.name == 'benchmark' || github.ref == 'refs/heads/main')
     with:
-      ec2_instance_type: t4g.small
-      ec2_ami: ubuntu-latest (aarch64)
-      archflags: -mcpu=cortex-a76 -march=armv8.2-a
-      cflags: -DFORCE_AARCH64
+      ec2_instance_type: ${{ matrix.target.ec2_instance_type }}
+      ec2_ami: ${{ matrix.target.ec2_ami }}
+      archflags: ${{ matrix.target.archflags }}
+      cflags: ${{ matrix.target.cflags }}
       opt: ${{ matrix.opt.value }}
-      store_results: true
-      name: Graviton2
-    secrets: inherit
-  bench-gv3:
-    name: Graviton3 ${{ matrix.opt.name }}
-    permissions:
-      contents: 'read'
-      id-token: 'write'
-    strategy:
-      fail-fast: false
-      matrix:
-        opt:
-          - name: opt
-            value: true
-          - name: non-opt
-            value: false
-    uses: ./.github/workflows/bench_ec2_reusable.yml
-    if: github.repository_owner == 'pq-code-package' && (github.event.label.name == 'benchmark' || github.ref == 'refs/heads/main')
-    with:
-      ec2_instance_type: c7g.medium
-      ec2_ami: ubuntu-latest (aarch64)
-      archflags: -mcpu=neoverse-v1 -march=armv8.4-a
-      cflags: -DFORCE_AARCH64
-      opt: ${{ matrix.opt.value }}
-      store_results: true
-      name: Graviton3
+      store_results: ${{ matrix.opt.value }} # Only store optimized results
+      name: ${{ matrix.target.name }}
     secrets: inherit