Switch Gv2 benchmark to t4g.small

Also, use archflags instead of cflags for -mcpu setting Signed-off-by: Hanno Becker <[email protected]>
pq-code-package · Sep 5, 2024 · 7ab0261 · 7ab0261
1 parent d52499a
commit 7ab0261
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/bench_ec2_all.yml b/.github/workflows/bench_ec2_all.yml
@@ -17,8 +17,7 @@ jobs:
     with:
       ec2_instance_type: c6g.medium
       ec2_ami_id: ami-096ea6a12ea24a797
-      cflags: -mcpu=cortex-a76
-      archflags: -march=armv8.2-a
+      archflags: -mcpu=cortex-a76 -march=armv8.2-a
       store_results: 'true'
       name: Graviton2
     secrets: inherit
@@ -32,8 +31,7 @@ jobs:
     with:
       ec2_instance_type: c7g.medium
       ec2_ami_id: ami-096ea6a12ea24a797
-      cflags: -mcpu=neoverse-v1
-      archflags: -march=armv8.4-a
+      archflags: -mcpu=neoverse-v1 -march=armv8.4-a
       store_results: 'true'
       name: Graviton3
     secrets: inherit
diff --git a/.github/workflows/bench_ec2_any.yml b/.github/workflows/bench_ec2_any.yml
@@ -13,10 +13,10 @@ on:
         default: ami-096ea6a12ea24a797
       cflags:
         description: Custom CFLAGS for compilation
-        default: -mcpu=cortex-a76
+        default:
       archflags:
         description: Custom ARCH flags for compilation
-        default: -march=armv8.2-a
+        default: -mcpu=cortex-a76 -march=armv8.2-a
       store_results:
         description: Indicates if results should be pushed to github pages
         default: false

diff --git a/.github/workflows/bench_ec2_reusable.yml b/.github/workflows/bench_ec2_reusable.yml
@@ -9,19 +9,19 @@ on:
       ec2_instance_type:
         type: string
         description: Type if EC2 instance to benchmark on
-        default: c6g.medium
+        default: t4g.small
       ec2_ami_id:
         type: string
         description: AMI ID
         default: ami-096ea6a12ea24a797
       cflags:
         type: string
         description: Custom CFLAGS for compilation
-        default: -mcpu=cortex-a76
+        default:
       archflags:
         type: string
         description: Custom ARCH flags for compilation
-        default: -march=armv8.2-a
+        default: -mcpu=neoverse-n1 -march=armv8.2-a
       store_results:
         type: string
         description: Indicates if results should be pushed to github pages
@@ -82,7 +82,7 @@ jobs:
       - name: Run benchmark
         shell: nix develop .#ci -c bash -e {0}
         run: |
-          tests bench -c PERF --cflags ${{ inputs.cflags }} --arch-flags ${{ inputs.archflags }} -v --output output.json
+          tests bench -c PERF --cflags "${{ inputs.cflags }}" --arch-flags "${{ inputs.archflags }}" -v --output output.json
       - name: Dump benchmark
         if: ${{ inputs.store_results != 'true' }}
         run: |