Skip to content

Commit

Permalink
Merge pull request #478 from pq-code-package/fix-token-permission
Browse files Browse the repository at this point in the history
Fix Token Permission Again
  • Loading branch information
mkannwischer authored Dec 3, 2024
2 parents 41b272f + 0831b9d commit 6ce990f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions: read-all
permissions:
contents: read
pull-requests: read

jobs:
bench:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/bench_ec2_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ env:
AMI_UBUNTU_LATEST_X86_64: ami-0e86e20dae9224db8
AMI_UBUNTU_LATEST_AARCH64: ami-096ea6a12ea24a797

permissions: read-all
permissions:
contents: read
pull-requests: read

jobs:
start-ec2-runner:
Expand Down

17 comments on commit 6ce990f

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A76 (Raspberry Pi 5) benchmarks

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 29176 cycles 29175 cycles 1.00
ML-KEM-512 encaps 35851 cycles 35851 cycles 1
ML-KEM-512 decaps 46653 cycles 46653 cycles 1
ML-KEM-768 keypair 49177 cycles 49178 cycles 1.00
ML-KEM-768 encaps 55840 cycles 55839 cycles 1.00
ML-KEM-768 decaps 71009 cycles 71008 cycles 1.00
ML-KEM-1024 keypair 72213 cycles 72212 cycles 1.00
ML-KEM-1024 encaps 81523 cycles 81518 cycles 1.00
ML-KEM-1024 decaps 102027 cycles 102030 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 13918 cycles 13861 cycles 1.00
ML-KEM-512 encaps 18219 cycles 18214 cycles 1.00
ML-KEM-512 decaps 24133 cycles 24103 cycles 1.00
ML-KEM-768 keypair 22423 cycles 22505 cycles 1.00
ML-KEM-768 encaps 24575 cycles 24586 cycles 1.00
ML-KEM-768 decaps 32626 cycles 32753 cycles 1.00
ML-KEM-1024 keypair 32145 cycles 32148 cycles 1.00
ML-KEM-1024 encaps 35673 cycles 35665 cycles 1.00
ML-KEM-1024 decaps 47323 cycles 47314 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 20325 cycles 20326 cycles 1.00
ML-KEM-512 encaps 27127 cycles 27123 cycles 1.00
ML-KEM-512 decaps 36213 cycles 36217 cycles 1.00
ML-KEM-768 keypair 34857 cycles 34845 cycles 1.00
ML-KEM-768 encaps 38217 cycles 38202 cycles 1.00
ML-KEM-768 decaps 51402 cycles 51356 cycles 1.00
ML-KEM-1024 keypair 48094 cycles 48054 cycles 1.00
ML-KEM-1024 encaps 54247 cycles 54224 cycles 1.00
ML-KEM-1024 decaps 72161 cycles 72113 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 18207 cycles 18150 cycles 1.00
ML-KEM-512 encaps 23125 cycles 23132 cycles 1.00
ML-KEM-512 decaps 30388 cycles 30435 cycles 1.00
ML-KEM-768 keypair 31088 cycles 31031 cycles 1.00
ML-KEM-768 encaps 33989 cycles 33984 cycles 1.00
ML-KEM-768 decaps 44894 cycles 44896 cycles 1.00
ML-KEM-1024 keypair 44796 cycles 44669 cycles 1.00
ML-KEM-1024 encaps 50021 cycles 50032 cycles 1.00
ML-KEM-1024 decaps 64761 cycles 64762 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 15070 cycles 15068 cycles 1.00
ML-KEM-512 encaps 19759 cycles 19757 cycles 1.00
ML-KEM-512 decaps 26401 cycles 26408 cycles 1.00
ML-KEM-768 keypair 25738 cycles 25692 cycles 1.00
ML-KEM-768 encaps 28192 cycles 28348 cycles 0.99
ML-KEM-768 decaps 38199 cycles 38590 cycles 0.99
ML-KEM-1024 keypair 35662 cycles 35688 cycles 1.00
ML-KEM-1024 encaps 41237 cycles 41237 cycles 1
ML-KEM-1024 decaps 54744 cycles 54641 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i) (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 36296 cycles 36145 cycles 1.00
ML-KEM-512 encaps 46306 cycles 46363 cycles 1.00
ML-KEM-512 decaps 61607 cycles 61816 cycles 1.00
ML-KEM-768 keypair 58855 cycles 58998 cycles 1.00
ML-KEM-768 encaps 72584 cycles 73183 cycles 0.99
ML-KEM-768 decaps 91279 cycles 91692 cycles 1.00
ML-KEM-1024 keypair 88811 cycles 88548 cycles 1.00
ML-KEM-1024 encaps 109324 cycles 109254 cycles 1.00
ML-KEM-1024 decaps 132904 cycles 133626 cycles 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 18266 cycles 18263 cycles 1.00
ML-KEM-512 encaps 22477 cycles 22477 cycles 1
ML-KEM-512 decaps 29400 cycles 29404 cycles 1.00
ML-KEM-768 keypair 30773 cycles 30771 cycles 1.00
ML-KEM-768 encaps 34059 cycles 34060 cycles 1.00
ML-KEM-768 decaps 43910 cycles 43909 cycles 1.00
ML-KEM-1024 keypair 44482 cycles 44484 cycles 1.00
ML-KEM-1024 encaps 50207 cycles 50203 cycles 1.00
ML-KEM-1024 decaps 63631 cycles 63634 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 19032 cycles 19030 cycles 1.00
ML-KEM-512 encaps 23845 cycles 23841 cycles 1.00
ML-KEM-512 decaps 31230 cycles 31229 cycles 1.00
ML-KEM-768 keypair 32333 cycles 32333 cycles 1
ML-KEM-768 encaps 36083 cycles 36088 cycles 1.00
ML-KEM-768 decaps 46493 cycles 46492 cycles 1.00
ML-KEM-1024 keypair 46969 cycles 46971 cycles 1.00
ML-KEM-1024 encaps 53086 cycles 53088 cycles 1.00
ML-KEM-1024 decaps 67405 cycles 67402 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A55 (Snapdragon 888) benchmarks

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 58016 cycles 58017 cycles 1.00
ML-KEM-512 encaps 65688 cycles 65649 cycles 1.00
ML-KEM-512 decaps 84278 cycles 84387 cycles 1.00
ML-KEM-768 keypair 98227 cycles 98250 cycles 1.00
ML-KEM-768 encaps 110272 cycles 110516 cycles 1.00
ML-KEM-768 decaps 136639 cycles 136636 cycles 1.00
ML-KEM-1024 keypair 149130 cycles 149247 cycles 1.00
ML-KEM-1024 encaps 166256 cycles 166202 cycles 1.00
ML-KEM-1024 decaps 202343 cycles 201450 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i) (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 56724 cycles 56680 cycles 1.00
ML-KEM-512 encaps 71764 cycles 71750 cycles 1.00
ML-KEM-512 decaps 96315 cycles 96278 cycles 1.00
ML-KEM-768 keypair 91789 cycles 91763 cycles 1.00
ML-KEM-768 encaps 111396 cycles 111379 cycles 1.00
ML-KEM-768 decaps 144613 cycles 144447 cycles 1.00
ML-KEM-1024 keypair 134534 cycles 134508 cycles 1.00
ML-KEM-1024 encaps 159964 cycles 160080 cycles 1.00
ML-KEM-1024 decaps 201356 cycles 201322 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a) (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 52330 cycles 52304 cycles 1.00
ML-KEM-512 encaps 67782 cycles 67779 cycles 1.00
ML-KEM-512 decaps 92630 cycles 92604 cycles 1.00
ML-KEM-768 keypair 84688 cycles 84654 cycles 1.00
ML-KEM-768 encaps 104906 cycles 104872 cycles 1.00
ML-KEM-768 decaps 137848 cycles 137775 cycles 1.00
ML-KEM-1024 keypair 125830 cycles 125460 cycles 1.00
ML-KEM-1024 encaps 149763 cycles 149731 cycles 1.00
ML-KEM-1024 decaps 192318 cycles 192226 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a) (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 45946 cycles 45695 cycles 1.01
ML-KEM-512 encaps 58762 cycles 58760 cycles 1.00
ML-KEM-512 decaps 79995 cycles 79966 cycles 1.00
ML-KEM-768 keypair 74601 cycles 74604 cycles 1.00
ML-KEM-768 encaps 91466 cycles 91439 cycles 1.00
ML-KEM-768 decaps 120171 cycles 120092 cycles 1.00
ML-KEM-1024 keypair 109869 cycles 109856 cycles 1.00
ML-KEM-1024 encaps 130986 cycles 130961 cycles 1.00
ML-KEM-1024 decaps 167659 cycles 167639 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 29179 cycles 29178 cycles 1.00
ML-KEM-512 encaps 35864 cycles 35864 cycles 1
ML-KEM-512 decaps 46672 cycles 46673 cycles 1.00
ML-KEM-768 keypair 49199 cycles 49209 cycles 1.00
ML-KEM-768 encaps 55871 cycles 55880 cycles 1.00
ML-KEM-768 decaps 70992 cycles 71002 cycles 1.00
ML-KEM-1024 keypair 72290 cycles 72179 cycles 1.00
ML-KEM-1024 encaps 81760 cycles 81622 cycles 1.00
ML-KEM-1024 decaps 102284 cycles 102075 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4 (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 41899 cycles 41906 cycles 1.00
ML-KEM-512 encaps 51761 cycles 51760 cycles 1.00
ML-KEM-512 decaps 69324 cycles 69329 cycles 1.00
ML-KEM-768 keypair 69050 cycles 69058 cycles 1.00
ML-KEM-768 encaps 82685 cycles 82684 cycles 1.00
ML-KEM-768 decaps 106473 cycles 106475 cycles 1.00
ML-KEM-1024 keypair 102250 cycles 102258 cycles 1.00
ML-KEM-1024 encaps 120658 cycles 120658 cycles 1
ML-KEM-1024 decaps 150706 cycles 150723 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3 (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 45372 cycles 45365 cycles 1.00
ML-KEM-512 encaps 56178 cycles 56171 cycles 1.00
ML-KEM-512 decaps 75100 cycles 75096 cycles 1.00
ML-KEM-768 keypair 74874 cycles 74861 cycles 1.00
ML-KEM-768 encaps 89188 cycles 89183 cycles 1.00
ML-KEM-768 decaps 114552 cycles 114538 cycles 1.00
ML-KEM-1024 keypair 111084 cycles 111080 cycles 1.00
ML-KEM-1024 encaps 129999 cycles 129992 cycles 1.00
ML-KEM-1024 decaps 162589 cycles 162574 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2 (no-opt)

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 71118 cycles 71117 cycles 1.00
ML-KEM-512 encaps 87833 cycles 87847 cycles 1.00
ML-KEM-512 decaps 118145 cycles 118161 cycles 1.00
ML-KEM-768 keypair 117237 cycles 117604 cycles 1.00
ML-KEM-768 encaps 139206 cycles 139373 cycles 1.00
ML-KEM-768 decaps 180051 cycles 180134 cycles 1.00
ML-KEM-1024 keypair 173974 cycles 175419 cycles 0.99
ML-KEM-1024 encaps 201819 cycles 202932 cycles 0.99
ML-KEM-1024 decaps 253360 cycles 254266 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

@oqs-bot oqs-bot commented on 6ce990f Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A72 (Raspberry Pi 4) benchmarks

Benchmark suite Current: 6ce990f Previous: 7294554 Ratio
ML-KEM-512 keypair 51271 cycles 52196 cycles 0.98
ML-KEM-512 encaps 58339 cycles 60404 cycles 0.97
ML-KEM-512 decaps 74884 cycles 75367 cycles 0.99
ML-KEM-768 keypair 87804 cycles 87866 cycles 1.00
ML-KEM-768 encaps 97050 cycles 98435 cycles 0.99
ML-KEM-768 decaps 120020 cycles 121026 cycles 0.99
ML-KEM-1024 keypair 132374 cycles 132226 cycles 1.00
ML-KEM-1024 encaps 146232 cycles 145950 cycles 1.00
ML-KEM-1024 decaps 178060 cycles 177465 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.