Skip to content

Commit

Permalink
Bench: Store non-opt benchmarks on GH pages
Browse files Browse the repository at this point in the history
Until now, we only pushed benchmarks for optimized code to the
github pages. That was the wrong decision, as we are now curious
to understand (a) where mlkem-native's pure-C performance stands
in comparison to the reference implementation, and (b) how it has
evolved over time, esp. in light of restructurings we made for the
CBMC proofs.

Ultimately, we should retroactively conduct & push non-opt benchmarks.
For now, this commit merely enables pushing benchmarking results to
GH pages for non-optimized code.

Care needs to be taken to not mess up with existing optimized benchmarks
by changing their name. Thus, we keep the previous names (which matched
the target name, e.g. "Graviton 3"), but append " (no-opt)" in case we
benchmarked the C backend.

Signed-off-by: Hanno Becker <[email protected]>
  • Loading branch information
hanno-becker committed Nov 17, 2024
1 parent 2944872 commit 602ebfc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,6 @@ jobs:
archflags: ${{ matrix.target.archflags }}
cflags: ${{ matrix.target.cflags }}
opt: ${{ matrix.opt.value }}
store_results: ${{ matrix.opt.value && github.repository_owner == 'pq-code-package' && github.ref == 'refs/heads/main' }} # Only store optimized results
name: ${{ matrix.target.name }}
store_results: ${{ github.repository_owner == 'pq-code-package' && github.ref == 'refs/heads/main' }} # Only store optimized results
name: ${{ matrix.target.name }}${{ !matrix.opt.value && " (no-opt)" }}
secrets: inherit

0 comments on commit 602ebfc

Please sign in to comment.