Skip to content

Commit

Permalink
Merge pull request #594 from pq-code-package/namespace_cruft
Browse files Browse the repository at this point in the history 
Remove unused namespace macro
  • Loading branch information
@mkannwischer
mkannwischer authored Dec 31, 2024
2 parents ceb3e2d + 625c277 commit 5b4572e
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions mlkem/namespace.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@
#define MLKEM_DEFAULT_NAMESPACE(s) \
__MLKEM_DEFAULT_NAMESPACE(PQCP_MLKEM_NATIVE, MLKEM_PARAM_NAME, \
MLKEM_NATIVE_ARITH_BACKEND_NAME, s)
#define _MLKEM_DEFAULT_NAMESPACE(s) \
__MLKEM_DEFAULT_NAMESPACE(_PQCP_MLKEM_NATIVE, MLKEM_PARAM_NAME, \
MLKEM_NATIVE_ARITH_BACKEND_NAME, s)

#if !defined(MLKEM_NATIVE_FIPS202_BACKEND_NAME)
#define MLKEM_NATIVE_FIPS202_BACKEND_NAME C
Expand All @@ -50,8 +47,5 @@
#define FIPS202_DEFAULT_NAMESPACE(s) \
__FIPS202_DEFAULT_NAMESPACE(PQCP_MLKEM_NATIVE_FIPS202, \
MLKEM_NATIVE_FIPS202_BACKEND_NAME, s)
#define _FIPS202_DEFAULT_NAMESPACE(s) \
__FIPS202_DEFAULT_NAMESPACE(_PQCP_MLKEM_NATIVE_FIPS202, \
MLKEM_NATIVE_FIPS202_BACKEND_NAME, s)

#endif /* MLKEM_NATIVE_NAMESPACE_H */

17 comments on commit 5b4572e

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A76 (Raspberry Pi 5) benchmarks

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 29018 cycles 29016 cycles 1.00
ML-KEM-512 encaps 35398 cycles 35396 cycles 1.00
ML-KEM-512 decaps 45885 cycles 45882 cycles 1.00
ML-KEM-768 keypair 49354 cycles 49348 cycles 1.00
ML-KEM-768 encaps 55573 cycles 55573 cycles 1
ML-KEM-768 decaps 70333 cycles 70331 cycles 1.00
ML-KEM-1024 keypair 72070 cycles 72075 cycles 1.00
ML-KEM-1024 encaps 80842 cycles 80841 cycles 1.00
ML-KEM-1024 decaps 100679 cycles 100679 cycles 1

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 13943 cycles 13539 cycles 1.03
ML-KEM-512 encaps 17223 cycles 17350 cycles 0.99
ML-KEM-512 decaps 23029 cycles 23102 cycles 1.00
ML-KEM-768 keypair 22522 cycles 22547 cycles 1.00
ML-KEM-768 encaps 24590 cycles 24527 cycles 1.00
ML-KEM-768 decaps 32646 cycles 32638 cycles 1.00
ML-KEM-1024 keypair 31403 cycles 31392 cycles 1.00
ML-KEM-1024 encaps 34911 cycles 34926 cycles 1.00
ML-KEM-1024 decaps 45844 cycles 45819 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 15106 cycles 15075 cycles 1.00
ML-KEM-512 encaps 19685 cycles 19663 cycles 1.00
ML-KEM-512 decaps 26333 cycles 26307 cycles 1.00
ML-KEM-768 keypair 25604 cycles 25626 cycles 1.00
ML-KEM-768 encaps 28163 cycles 28174 cycles 1.00
ML-KEM-768 decaps 37887 cycles 37977 cycles 1.00
ML-KEM-1024 keypair 35660 cycles 35676 cycles 1.00
ML-KEM-1024 encaps 40970 cycles 41043 cycles 1.00
ML-KEM-1024 decaps 54485 cycles 54487 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 20337 cycles 20348 cycles 1.00
ML-KEM-512 encaps 26997 cycles 27019 cycles 1.00
ML-KEM-512 decaps 35820 cycles 35853 cycles 1.00
ML-KEM-768 keypair 34875 cycles 34909 cycles 1.00
ML-KEM-768 encaps 38165 cycles 38196 cycles 1.00
ML-KEM-768 decaps 50895 cycles 50925 cycles 1.00
ML-KEM-1024 keypair 48008 cycles 47967 cycles 1.00
ML-KEM-1024 encaps 54211 cycles 54143 cycles 1.00
ML-KEM-1024 decaps 71730 cycles 71725 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 18139 cycles 18141 cycles 1.00
ML-KEM-512 encaps 23201 cycles 23187 cycles 1.00
ML-KEM-512 decaps 30493 cycles 30609 cycles 1.00
ML-KEM-768 keypair 31067 cycles 31080 cycles 1.00
ML-KEM-768 encaps 34176 cycles 34169 cycles 1.00
ML-KEM-768 decaps 44728 cycles 44744 cycles 1.00
ML-KEM-1024 keypair 44590 cycles 44597 cycles 1.00
ML-KEM-1024 encaps 49889 cycles 49896 cycles 1.00
ML-KEM-1024 decaps 64360 cycles 64367 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i) (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 34901 cycles 34978 cycles 1.00
ML-KEM-512 encaps 45096 cycles 45092 cycles 1.00
ML-KEM-512 decaps 58976 cycles 59055 cycles 1.00
ML-KEM-768 keypair 59147 cycles 59103 cycles 1.00
ML-KEM-768 encaps 71793 cycles 71745 cycles 1.00
ML-KEM-768 decaps 89280 cycles 89300 cycles 1.00
ML-KEM-1024 keypair 87836 cycles 87547 cycles 1.00
ML-KEM-1024 encaps 104139 cycles 104684 cycles 0.99
ML-KEM-1024 decaps 126880 cycles 127591 cycles 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 18968 cycles 18966 cycles 1.00
ML-KEM-512 encaps 23557 cycles 23553 cycles 1.00
ML-KEM-512 decaps 30667 cycles 30662 cycles 1.00
ML-KEM-768 keypair 32295 cycles 32294 cycles 1.00
ML-KEM-768 encaps 35891 cycles 35888 cycles 1.00
ML-KEM-768 decaps 46037 cycles 46029 cycles 1.00
ML-KEM-1024 keypair 46630 cycles 46629 cycles 1.00
ML-KEM-1024 encaps 52446 cycles 52446 cycles 1
ML-KEM-1024 decaps 66243 cycles 66249 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a) (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 45719 cycles 45730 cycles 1.00
ML-KEM-512 encaps 56860 cycles 56860 cycles 1
ML-KEM-512 decaps 76229 cycles 76230 cycles 1.00
ML-KEM-768 keypair 74512 cycles 74538 cycles 1.00
ML-KEM-768 encaps 88571 cycles 88608 cycles 1.00
ML-KEM-768 decaps 114397 cycles 114442 cycles 1.00
ML-KEM-1024 keypair 109387 cycles 109391 cycles 1.00
ML-KEM-1024 encaps 127235 cycles 127306 cycles 1.00
ML-KEM-1024 decaps 159962 cycles 160035 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 18137 cycles 18136 cycles 1.00
ML-KEM-512 encaps 22155 cycles 22155 cycles 1
ML-KEM-512 decaps 28790 cycles 28790 cycles 1
ML-KEM-768 keypair 30570 cycles 30570 cycles 1
ML-KEM-768 encaps 33633 cycles 33635 cycles 1.00
ML-KEM-768 decaps 43172 cycles 43173 cycles 1.00
ML-KEM-1024 keypair 44213 cycles 44208 cycles 1.00
ML-KEM-1024 encaps 49649 cycles 49661 cycles 1.00
ML-KEM-1024 decaps 62654 cycles 62654 cycles 1

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i) (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 56612 cycles 56643 cycles 1.00
ML-KEM-512 encaps 69431 cycles 69496 cycles 1.00
ML-KEM-512 decaps 91412 cycles 91430 cycles 1.00
ML-KEM-768 keypair 91848 cycles 91898 cycles 1.00
ML-KEM-768 encaps 107774 cycles 107778 cycles 1.00
ML-KEM-768 decaps 136291 cycles 136343 cycles 1.00
ML-KEM-1024 keypair 134777 cycles 134763 cycles 1.00
ML-KEM-1024 encaps 155233 cycles 155200 cycles 1.00
ML-KEM-1024 decaps 191574 cycles 191499 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a) (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 52126 cycles 52162 cycles 1.00
ML-KEM-512 encaps 65719 cycles 65771 cycles 1.00
ML-KEM-512 decaps 88326 cycles 88394 cycles 1.00
ML-KEM-768 keypair 84812 cycles 84812 cycles 1
ML-KEM-768 encaps 101513 cycles 101517 cycles 1.00
ML-KEM-768 decaps 132144 cycles 132153 cycles 1.00
ML-KEM-1024 keypair 124063 cycles 124286 cycles 1.00
ML-KEM-1024 encaps 146002 cycles 146097 cycles 1.00
ML-KEM-1024 decaps 183702 cycles 184102 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A55 (Snapdragon 888) benchmarks

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 58343 cycles 58366 cycles 1.00
ML-KEM-512 encaps 65760 cycles 65775 cycles 1.00
ML-KEM-512 decaps 84552 cycles 84551 cycles 1.00
ML-KEM-768 keypair 98940 cycles 99011 cycles 1.00
ML-KEM-768 encaps 110166 cycles 110322 cycles 1.00
ML-KEM-768 decaps 137215 cycles 137002 cycles 1.00
ML-KEM-1024 keypair 150195 cycles 149988 cycles 1.00
ML-KEM-1024 encaps 166586 cycles 166260 cycles 1.00
ML-KEM-1024 decaps 202638 cycles 202317 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 29057 cycles 29022 cycles 1.00
ML-KEM-512 encaps 35444 cycles 35402 cycles 1.00
ML-KEM-512 decaps 45952 cycles 45889 cycles 1.00
ML-KEM-768 keypair 49446 cycles 49361 cycles 1.00
ML-KEM-768 encaps 55700 cycles 55580 cycles 1.00
ML-KEM-768 decaps 70502 cycles 70301 cycles 1.00
ML-KEM-1024 keypair 72061 cycles 72018 cycles 1.00
ML-KEM-1024 encaps 80857 cycles 80794 cycles 1.00
ML-KEM-1024 decaps 100751 cycles 100665 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3 (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 45390 cycles 45393 cycles 1.00
ML-KEM-512 encaps 54217 cycles 54215 cycles 1.00
ML-KEM-512 decaps 71153 cycles 71149 cycles 1.00
ML-KEM-768 keypair 74832 cycles 74835 cycles 1.00
ML-KEM-768 encaps 86071 cycles 86066 cycles 1.00
ML-KEM-768 decaps 108818 cycles 108816 cycles 1.00
ML-KEM-1024 keypair 111125 cycles 111126 cycles 1.00
ML-KEM-1024 encaps 125929 cycles 125928 cycles 1.00
ML-KEM-1024 decaps 154629 cycles 154624 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4 (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 41974 cycles 41963 cycles 1.00
ML-KEM-512 encaps 50159 cycles 50161 cycles 1.00
ML-KEM-512 decaps 66048 cycles 66049 cycles 1.00
ML-KEM-768 keypair 69043 cycles 69051 cycles 1.00
ML-KEM-768 encaps 79762 cycles 79759 cycles 1.00
ML-KEM-768 decaps 101013 cycles 101017 cycles 1.00
ML-KEM-1024 keypair 102455 cycles 102208 cycles 1.00
ML-KEM-1024 encaps 117435 cycles 117205 cycles 1.00
ML-KEM-1024 decaps 143371 cycles 143672 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2 (no-opt)

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 71185 cycles 71244 cycles 1.00
ML-KEM-512 encaps 85068 cycles 85050 cycles 1.00
ML-KEM-512 decaps 112757 cycles 112737 cycles 1.00
ML-KEM-768 keypair 117228 cycles 117473 cycles 1.00
ML-KEM-768 encaps 135210 cycles 135189 cycles 1.00
ML-KEM-768 decaps 171943 cycles 171800 cycles 1.00
ML-KEM-1024 keypair 175127 cycles 175069 cycles 1.00
ML-KEM-1024 encaps 197155 cycles 197182 cycles 1.00
ML-KEM-1024 decaps 243401 cycles 243334 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@oqs-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bananapi bpi-f3 benchmarks

Benchmark suite Current: 5b4572e Previous: ceb3e2d Ratio
ML-KEM-512 keypair 335210 cycles 335173 cycles 1.00
ML-KEM-512 encaps 446012 cycles 445706 cycles 1.00
ML-KEM-512 decaps 594119 cycles 594010 cycles 1.00
ML-KEM-768 keypair 556367 cycles 556380 cycles 1.00
ML-KEM-768 encaps 698263 cycles 698359 cycles 1.00
ML-KEM-768 decaps 890040 cycles 890899 cycles 1.00
ML-KEM-1024 keypair 822140 cycles 821913 cycles 1.00
ML-KEM-1024 encaps 999635 cycles 999595 cycles 1.00
ML-KEM-1024 decaps 1230548 cycles 1230402 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.