Fix zero impedance subgraph #718

geofjamg · 2023-02-01T22:57:59Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

# Conflicts: # src/main/java/com/powsybl/openloadflow/network/GraphVizGraphBuilder.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkListenerTracer.java # src/test/resources/nb.dot # src/test/resources/sim1.dot # src/test/resources/sim1_disconnected.dot

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg · 2023-02-28T22:01:49Z

@annetill most of the code is here. There is still some failing tests but help would be welcome to finish the work.

Some unit test are not relevant anymore and need to be updated as they have been designed with the check done at loading time.
I suspect some tests to be wrong.
There is an issue with the shunt + gen controlling same bus (not same var and eq), so there is a bug somewhere.
we miss a lot of new unit test to test various spanning tree configurations.
...

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

src/main/java/com/powsybl/openloadflow/ac/AcTargetVector.java

annetill · 2023-03-27T18:27:27Z

src/main/java/com/powsybl/openloadflow/network/ShuntVoltageControl.java

@@ -12,8 +12,10 @@
 */
 public class ShuntVoltageControl extends DiscreteVoltageControl<LfShunt> {

+    private static final int PRIORITY = 2;


Indeed we have the hypothesis in main branch that transformers have an highest priority than shunts, but maybe we have to rethink about it. Or make it configurable one day...

Yes it should better be configurable

src/main/java/com/powsybl/openloadflow/network/LfBus.java

annetill · 2023-03-28T09:06:36Z

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java

@@ -177,8 +136,8 @@ public void updateSlackBuses() {
    }

    private void invalidateZeroImpedanceNetworks() {


Your work is really impressive but I think that maybe we have to rethink in a next PR in having just one status for zero impedance line, for DC and for AC calculation. I am not sure it is possible...

Yes I see than this badly designed but a better solution is not clear to me. To handle in a next work.

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBranch.java

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBranch.java

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

# Conflicts: # src/test/java/com/powsybl/openloadflow/ac/NonImpedantBranchDisablingTest.java

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

flo-dup · 2023-03-30T13:52:52Z

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

+            if (voltageControls.size() > 1) {
+                // we take the highest target voltage (why not...) and in case of equality the voltage control
+                // with the first controlled bus ID by alpha sort
+                voltageControls.sort(Comparator.<VoltageControl<?>>comparingDouble(VoltageControl::getTargetValue)


you don't need to sort, you can take the min instead (or the max if you revert your comparator, not sure what's clearer!), and then you don't need to check voltageControls size, the loop reducing to something like

voltageControls.stream().max(vcComparator).ifPresent(mainVc -> linkAllVoltageControls(mainVc, voltageControls));

flo-dup · 2023-03-30T14:15:09Z

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

+            for (VoltageControl<?> vc : zb.getVoltageControls()) {
+                voltageControlsByType.computeIfAbsent(vc.getType(), k -> new ArrayList<>())
+                        .add(vc);
+                vc.getMergedDependentVoltageControls().clear();


Rather than giving access to the list we could have VoltageControl::getMergedDependentVoltageControlStream() and VoltageControl::clearMergedDependentVoltageControls()

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

flo-dup · 2023-03-30T16:06:43Z

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystemCreator.java

+                            .setActive(true);
+                }
+
+                // activate distribution equation and deactivate control equation at all enabled controller buses except one (first)


The comment does not correspond exactly to what's done (the except one is only for distribution equation)

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

sonarcloud · 2023-03-31T09:03:28Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

92.6% Coverage
0.0% Duplication

flo-dup

Nice job! 🎉

geofjamg added 5 commits February 1, 2023 22:01

Fix zero impedance subgraph

0f4d9a8

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

3133321

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

9f9c033

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

bc1ca8e

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

b0f1a9c

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg changed the title ~~Fix zero impedance subgraph~~ [WIP] Fix zero impedance subgraph Feb 1, 2023

geofjamg and others added 23 commits February 15, 2023 21:38

Merge branch 'main' into fix_zero_imp_subgraph

211009c

Wip

d1a0d9b

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

50709c7

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

a9e33b1

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

b2a93a5

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

72d5e15

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

3f35404

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

ac6aa0a

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

6b7d89f

Wip

bd47d0d

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

99aff81

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

1162b2f

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

bd3fe0f

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

fe4a155

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Wip

a9e1551

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

dfd859a

Merge branch 'main' into fix_zero_imp_subgraph

b323e9f

Wip

d13fb55

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

7823117

Wip

b3a9c7e

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

f58531a

Wip

b85a583

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg added 3 commits March 25, 2023 20:56

Fix

40a1a85

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

c6dde16

Fix

080c6aa

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

annetill added PR: next-release ready-for-review labels Mar 27, 2023

Clean.

9de748b

Signed-off-by: Anne Tilloy <[email protected]>

annetill requested changes Mar 28, 2023

View reviewed changes

flo-dup requested changes Mar 28, 2023

View reviewed changes

geofjamg and others added 8 commits March 28, 2023 17:40

Review fixes

503c7a2

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

ab34aaa

# Conflicts: # src/test/java/com/powsybl/openloadflow/ac/NonImpedantBranchDisablingTest.java

Merge branch 'main' into fix_zero_imp_subgraph

f4cfcda

Add unit test.

7b91c4f

Signed-off-by: Anne Tilloy <[email protected]>

Merge branch 'main' into fix_zero_imp_subgraph

6770a95

Clean

a33e7a3

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Clean

ded1edd

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Add comments

0a9b99d

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg changed the title ~~[WIP] Fix zero impedance subgraph~~ Fix zero impedance subgraph Mar 29, 2023

Merge.

68139bd

Signed-off-by: Anne Tilloy <[email protected]>

annetill approved these changes Mar 30, 2023

View reviewed changes

annetill mentioned this pull request Mar 30, 2023

Support of BusbarSectionContingency for everything #667

Merged

5 tasks

Fix

f8d1770

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg commented Mar 30, 2023

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/LfZeroImpedanceNetwork.java Show resolved Hide resolved

Merge branch 'main' into fix_zero_imp_subgraph

6edecc2

flo-dup reviewed Mar 31, 2023

View reviewed changes

Review fixes

ce20530

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

flo-dup approved these changes Mar 31, 2023

View reviewed changes

flo-dup merged commit cd1136b into main Mar 31, 2023

flo-dup deleted the fix_zero_imp_subgraph branch March 31, 2023 09:32

annetill mentioned this pull request Apr 5, 2023

Merged voltage control separated by a switch contingency #630

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix zero impedance subgraph #718

Fix zero impedance subgraph #718

geofjamg commented Feb 1, 2023

geofjamg commented Feb 28, 2023

annetill Mar 27, 2023

geofjamg Mar 28, 2023

annetill Mar 28, 2023

geofjamg Mar 28, 2023

flo-dup Mar 30, 2023

flo-dup Mar 30, 2023

flo-dup Mar 30, 2023

sonarcloud bot commented Mar 31, 2023

flo-dup left a comment

		@@ -177,8 +136,8 @@ public void updateSlackBuses() {
		}

		private void invalidateZeroImpedanceNetworks() {

Fix zero impedance subgraph #718

Fix zero impedance subgraph #718

Conversation

geofjamg commented Feb 1, 2023

geofjamg commented Feb 28, 2023

annetill Mar 27, 2023

Choose a reason for hiding this comment

geofjamg Mar 28, 2023

Choose a reason for hiding this comment

annetill Mar 28, 2023

Choose a reason for hiding this comment

geofjamg Mar 28, 2023

Choose a reason for hiding this comment

flo-dup Mar 30, 2023

Choose a reason for hiding this comment

flo-dup Mar 30, 2023

Choose a reason for hiding this comment

flo-dup Mar 30, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Mar 31, 2023

flo-dup left a comment

Choose a reason for hiding this comment