Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plonky3 keccak optimization #2089

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Plonky3 keccak optimization #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
2784378
messed up commit history again...
qwang98 Sep 13, 2024
e96fca7
test passed'
qwang98 Sep 13, 2024
3f0a7a8
fixed comments'
qwang98 Sep 13, 2024
6c82727
used unchagnd api
qwang98 Sep 13, 2024
f4b3376
just to rerun CI
qwang98 Sep 16, 2024
a0feb54
minor
qwang98 Sep 16, 2024
628eb79
Merge branch 'main' into plonky3-keccak-new-new
qwang98 Sep 16, 2024
6cba5dc
removed reverse
qwang98 Sep 16, 2024
98a6ea2
fix
qwang98 Sep 17, 2024
79045b0
example for chris
qwang98 Sep 17, 2024
49e2670
not the pil
qwang98 Sep 17, 2024
29a203d
some failed attempts of adapting to nested array
qwang98 Sep 17, 2024
66ad3af
all fixed
qwang98 Sep 17, 2024
6a0de54
remove txt
qwang98 Sep 17, 2024
73c608d
added keccakf to test pipeline
qwang98 Sep 18, 2024
0bfc318
fix from georg
qwang98 Sep 23, 2024
d36392c
POC for keccak memory
qwang98 Sep 24, 2024
ce1e6ad
deleted unwanted
qwang98 Sep 24, 2024
1b9975a
Merge branch 'main' into plonky3-keccak-memory-new
qwang98 Sep 24, 2024
03d502a
Merge branch 'main' into plonky3-keccak-memory-new
qwang98 Oct 19, 2024
f51f03a
revamped memory machine; still have bugs in witgen
qwang98 Oct 20, 2024
256c9a0
modified memory address calculation to start from final step latch ro…
qwang98 Oct 23, 2024
205b51a
keccak memory works fully
qwang98 Oct 26, 2024
b0499e9
added detailed comments on methodology and efficiency
qwang98 Oct 26, 2024
56cefaa
removed outdated memory submachine tests
qwang98 Oct 26, 2024
3a15b65
addressed all comments
qwang98 Nov 4, 2024
061c256
Merge branch 'main' into plonky3-keccak-memory-new
qwang98 Nov 4, 2024
0bda79a
created address_inc_cond function that uses increment_ptr; witness ge…
qwang98 Nov 4, 2024
fa8a4cc
moved pointer coinstraints to addr_h and addr_l columns
qwang98 Nov 14, 2024
2f65fb9
Merge branch 'main' into plonky3-keccak-memory-new-new
qwang98 Nov 14, 2024
931a5d6
updated pipeline
qwang98 Nov 14, 2024
c6dd8fd
fixed high degree
qwang98 Nov 25, 2024
fbd45ca
merge main
qwang98 Nov 25, 2024
d12fa46
weird witgen bug emerged again
qwang98 Nov 25, 2024
67414af
successful calculation of input and output addresses using inverse an…
qwang98 Nov 25, 2024
11972db
changing MAX_ROUNDS_PER_ROW_DELTA to 102 or above solves the bug and …
qwang98 Nov 25, 2024
06d40f4
removed print statement due to CI error
qwang98 Nov 26, 2024
5ad8bec
delete unrelated output
qwang98 Nov 26, 2024
096560e
deleted output txt example:
qwang98 Dec 6, 2024
f3a2230
fix test
leonardoalt Dec 9, 2024
88e860c
Merge remote-tracking branch 'origin/main' into plonky3-keccak-memory…
leonardoalt Dec 9, 2024
ae5deab
fix merge
leonardoalt Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion executor/src/witgen/sequence_iterator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub struct DefaultSequenceIterator {
progress_steps: Vec<SequenceStep>,
}

const MAX_ROUNDS_PER_ROW_DELTA: usize = 100;
const MAX_ROUNDS_PER_ROW_DELTA: usize = 102;

impl DefaultSequenceIterator {
pub fn new(block_size: usize, identities_count: usize, outer_query_row: Option<i64>) -> Self {
Expand Down
Loading