Skip to content

Commit

Permalink
Only run for Goldilocks
Browse files Browse the repository at this point in the history
  • Loading branch information
georgwiese committed Dec 4, 2024
1 parent 41fbbe7 commit c8a7ab6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion executor/src/witgen/bus_accumulator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ fn interaction_columns<T: FieldElement>(
.unwrap();
let intermediate_definitions = pil.intermediate_definitions();

let size = trace_values.len();
let size = trace_values.height();
let mut acc1 = vec![T::zero(); size];
let mut acc2 = vec![T::zero(); size];
let mut acc1_next = vec![T::zero(); size];
Expand Down
2 changes: 1 addition & 1 deletion executor/src/witgen/expression_evaluator2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ impl<T> OwnedTraceValues<T> {
Self { values }
}

pub fn len(&self) -> usize {
pub fn height(&self) -> usize {
self.values.values().next().map(|v| v.len()).unwrap()
}

Expand Down
4 changes: 2 additions & 2 deletions executor/src/witgen/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use powdr_ast::analyzed::{
};
use powdr_ast::parsed::visitor::{AllChildren, ExpressionVisitable};
use powdr_ast::parsed::{FunctionKind, LambdaExpression};
use powdr_number::{DegreeType, FieldElement};
use powdr_number::{DegreeType, FieldElement, KnownField};
use std::iter::once;

use crate::constant_evaluator::VariablySizedColumn;
Expand Down Expand Up @@ -136,7 +136,7 @@ impl<T: FieldElement> WitgenCallbackContext<T> {
.iter()
.any(|identity| matches!(identity, Identity::PhantomBusInteraction(_)));

if has_phantom_bus_sends {
if has_phantom_bus_sends && T::known_field() == Some(KnownField::GoldilocksField) {
log::debug!("Using hand-written bus witgen.");
let fixed_col_values = self.select_fixed_columns2(pil, size);
assert_eq!(stage, 1);
Expand Down

0 comments on commit c8a7ab6

Please sign in to comment.