Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/macOS 15 runner #334

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Chore/macOS 15 runner #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07146c7
macOS 15 runner
borut-t Sep 26, 2024
abd60a2
Device.
borut-t Sep 26, 2024
44fc5a5
Fix test.
borut-t Sep 26, 2024
d48dc79
Action condition.
borut-t Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/Tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: Tests

on:
push:
pull_request:
types: [opened, synchronize, reopened]

Expand All @@ -11,7 +10,7 @@ concurrency:

jobs:
Tests:
runs-on: macos-14-xlarge
runs-on: macos-15-xlarge
steps:
- name: Checkout Repository
uses: actions/checkout@v4
Expand All @@ -22,8 +21,8 @@ jobs:
xcode-version: latest-stable

- name: Build project
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 16 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions

- name: Run tests
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 16 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions

6 changes: 2 additions & 4 deletions Tests/Tests/Core/Extensions/UIKit/UIWindowTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
//

#if os(iOS)

import XCTest
import UIKit
import PovioKitCore
Expand All @@ -16,12 +15,11 @@ class UIWindowTests: XCTestCase {
func test_safeAreaInsets() {
let window = UIWindow()
window.makeKeyAndVisible()
// this values work for iPhone 14 flavors
XCTAssertEqual(window.safeAreaInsets.top, 59)
// this values work for iPhone 16 flavors
XCTAssertEqual(window.safeAreaInsets.top, 62)
XCTAssertEqual(window.safeAreaInsets.left, 0)
XCTAssertEqual(window.safeAreaInsets.right, 0)
XCTAssertEqual(window.safeAreaInsets.bottom, 34)
}
}

#endif
Loading