Add DB activity based routing #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdrsh
reviewed
Nov 17, 2024
| @@ -11,6 +12,7 @@ use sqlparser::ast::{ | |||
| }; | |||
| use sqlparser::dialect::PostgreSqlDialect; | |||
| use sqlparser::parser::Parser; | |||
| use std::sync::OnceLock; | |||
There was a problem hiding this comment.
We probably want to use the async version of this construct to avoid blocking the worker threads.
There was a problem hiding this comment.
A few reasons I'm wondering if it's worth it:
- This'll only happen once since it's initializing a static object.
- The init itself happens all in memory.
- The init uses all sync methods so i'll have to wrap it with an async method that doesn't have anything to await on.
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is an attempt to add support for primary-replica routing based on recent writes on the table level.
We've implemented this as a separate process alongside PgPool-II before.
This will perform much better as it's incorporated into PgCat itself.
You can read all about the approach here: https://medium.com/tailor-tech/using-database-read-replicas-in-distributed-systems-d80eaf6bbf8a