[Helm]: Generalize Password Lookup #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalizing the secret lookup functionality that was added in postgresml#753 to work for `admin_password`, `auth_query_password`, `server_password`, and really any other one. It works by creating a `pgcat.password` template which expects an object containing values for the `password` and `secret` keys. `password` is a literal value normally supplied via `.Values.xyz` value. `secret` is an object with a key and name property that effectively functions like a _secretKeyRef_. When the literal value is not blank, that is used. Otherwise an attempt is made to lookup to supplied key from the named secret and use that. This is exactly how the current implementation of `user_password` works, which avoids any breaking changes. See the function definition for more details. > Note: it seems like `user_passwordSecret` was added (camelCase name) while all the other ones are _snake_case_. I elected to use snake case for the new values, but left `user_passwordSecret` as is to avoid any breaking changes.
pseudomuto
commented
Oct 10, 2024
| @@ -5,4 +5,4 @@ maintainers: | |||
| - name: Wildcard | |||
| email: [email protected] | |||
| appVersion: "1.2.0" | |||
| version: 0.2.1 | |||
| version: 0.3.0 | |||
There was a problem hiding this comment.
Not sure if semver is strict here, but bumped to 0.3.0 since new, non-breaking functionality is added. Happy to make this 0.2.2 if that's preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Speissi @drdrsh for review
Generalizing the secret lookup functionality that was added in #753 to work for
admin_password,auth_query_password,server_password, and really any other one.It works by creating a
pgcat.passwordtemplate which expects an object containing values for thepasswordandsecretkeys.passwordis a literal value normally supplied via.Values.xyzvalue.secretis an object with a key and name property that effectively functions like a secretKeyRef.When the literal value is not blank, that is used. Otherwise an attempt is made to lookup to supplied key from the named secret and use that. This is exactly how the current implementation of
user_passwordworks, which avoids any breaking changes. See the function definition for more details.