fix type definitions #284
Merged
fix type definitions #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Nov 5, 2023
| @@ -166,7 +166,7 @@ declare namespace parser { | |||
| replaceWith(...nodes: Node[]): Node; | |||
| next(): Node; | |||
| prev(): Node; | |||
| clone(opts?: {[override: string]:any}): Node; | |||
| clone(opts?: {[override: string]:any}): this; | |||
There was a problem hiding this comment.
After cloning the return the value is always an instance of this.
With Node as the return type you always need to do more type checks after cloning because the specific type was erased.
Comment on lines
+214
to
+215
| append(selector: Child): this; | ||
| prepend(selector: Child): this; |
There was a problem hiding this comment.
I think this was a typo.
append/prepend have similar implementations as insertAfter/insertBefore and those have type Child
Comment on lines
+236
to
+237
| removeAll(): this; | ||
| empty(): this; |
There was a problem hiding this comment.
Same reason as the change in clone().
Returning this preserves the specific type of the current instance.
|
@alexander-akait Could you take a look at this when you have time? |
alexander-akait
approved these changes
Dec 6, 2023
|
A release would be awesome! Don't worry about taking your time with this :) |
romainmenke
deleted the
fix-type-definitions--diligent-collie-29b549818a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.