fix: Prevent throwing an exception if serviceUrl is not set

postalsys · Nov 11, 2024 · e947a0b · e947a0b
1 parent 9f996f1
commit e947a0b
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/workers/api.js b/workers/api.js
@@ -573,7 +573,15 @@ const init = async () => {
 
     let getServiceDomain = async () => {
         let serviceUrl = await settings.get('serviceUrl');
-        let hostname = (new URL(serviceUrl).hostname || '').toString().toLowerCase().trim();
+        let parsedUrl;
+
+        try {
+            parsedUrl = new URL(serviceUrl);
+        } catch (err) {
+            parsedUrl = {};
+        }
+
+        let hostname = (parsedUrl.hostname || '').toString().toLowerCase().trim();
         if (!hostname || net.isIP(hostname) || ['localhost'].includes(hostname) || /(\.local|\.lan)$/i.test(hostname)) {
             return false;
         }
@@ -8848,6 +8856,7 @@ init()
             maxBodySize: MAX_BODY_SIZE,
             version: packageData.version
         });
+
         parentPort.postMessage({ cmd: 'ready' });
     })
     .catch(err => {