Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception for X25519MLKEM768 naming #27

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Exception for X25519MLKEM768 naming #27

merged 1 commit into from
Dec 19, 2024

Conversation

kriskwiatkowski
Copy link
Member

No description provided.

@kriskwiatkowski kriskwiatkowski mentioned this pull request Dec 11, 2024
Open
@dconnolly
Copy link

This is not in compliance with -hybrid-design:

image

csosto-pk
csosto-pk reviewed Dec 11, 2024
View reviewed changes
draft-kwiatkowski-tls-ecdhe-mlkem.md
@@ -109,6 +109,10 @@ of the scheme, which will remain more ubiqutous for secp256r1 in the coming year
For this reason we put the ML-KEM shared secret first in X25519MLKEM768,
and the ECDH shared secret first in SecP256r1MLKEM768 and SecP384r1MLKEM1024.

Note: The group name X25519MLKEM768 does not adhere to the naming convention outlined in
{{Section 3.2 of hybrid}}. Specifically, the order of shares in the concatenation has been
reversed. This is due to historical reasons.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ctz
ctz approved these changes Dec 12, 2024
View reviewed changes
Copy link

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This situation is unfortunate but I think this direction leaves us with the minimum amount of mess.

@kriskwiatkowski
Copy link
Member Author

Let's merge it as this is current state of the art.
I don't think there is clear consensus regarding changing the name of X25519-MLKEM768. We will get a consensus after document is adopted.

@kriskwiatkowski kriskwiatkowski merged commit 0197886 into main Dec 19, 2024
2 checks passed
@kriskwiatkowski kriskwiatkowski deleted the kris/exception branch December 19, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csosto-pk csosto-pk csosto-pk approved these changes

@tomato42 tomato42 tomato42 approved these changes

@ctz ctz ctz approved these changes

@bwesterb bwesterb bwesterb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kriskwiatkowski @dconnolly @bwesterb @ctz @tomato42 @csosto-pk