document that error checking still needs to be performed #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidben
approved these changes
Oct 11, 2024
tomato42
force-pushed
the
alerts
branch
2 times, most recently
from
56dd7b0 to
a5bdbb7
Compare
FiloSottile
reviewed
Oct 12, 2024
tomato42
force-pushed
the
alerts
branch
2 times, most recently
from
4ae5182 to
c33aff0
Compare
bwesterb
reviewed
Oct 14, 2024
|
@tomato42 thank you for your understanding and perseverance. |
kriskwiatkowski
merged commit 1247554
into
post-quantum-cryptography:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All algorithms have inputs that are publicly invalid (be it ECDH, X25519, or ML-KEM), document that this error checking still needs to be performed and how errors need to be handled.