Use development version of shiny for Connect deployments. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Dec 5, 2023
karangattu
approved these changes
Dec 5, 2023
Co-authored-by: Carson Sievert <[email protected]>
|
@karangattu I have no memory of this PR, but looks like a dropped the ball on merging it, has it been superceded? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous deployment tests were not actually testing the development version of pyshiny on Connect. The way Connect deployment works is:
pip freezeSo when we had a requirments.txt file which specified
shinyit would install shiny from pypi which is to say that our deployment tests were always testing one version back.