chore(typography): Drop typography.base.color

For #27
posit-dev · Oct 16, 2024 · 69798ea · 69798ea
1 parent 3d33f18
commit 69798ea
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/docs/pkg/py/typography.qmd b/docs/pkg/py/typography.qmd
@@ -556,10 +556,6 @@ line_height
 :   The line height of the text. Line height refers to the vertical space
     between lines of text.
 
-color
-
-:   The color of the text. Can be any CSS-compatible color definition.
-
 ### BrandTypographyHeadings { #brand_yaml.typography.BrandTypographyHeadings }
 
 ```python

diff --git a/pkg-py/src/brand_yaml/typography.py b/pkg-py/src/brand_yaml/typography.py
@@ -852,7 +852,6 @@ class BrandTypographyBase(
     BrandTypographyOptionsWeight,
     BrandTypographyOptionsSize,
     BrandTypographyOptionsLineHeight,
-    BrandTypographyOptionsColor,
 ):
     """
     Typographic settings for base (or body) text.
@@ -869,8 +868,6 @@ class BrandTypographyBase(
     line_height
         The line height of the text. Line height refers to the vertical space
         between lines of text.
-    color
-        The color of the text. Can be any CSS-compatible color definition.
     """
 
     model_config = ConfigDict(extra="forbid")

diff --git a/pkg-py/tests/__snapshots__/test_typography/test_brand_typography_ex_color.json b/pkg-py/tests/__snapshots__/test_typography/test_brand_typography_ex_color.json
@@ -15,9 +15,6 @@
     }
   },
   "typography": {
-    "base": {
-      "color": "#1b1818"
-    },
     "fonts": [],
     "headings": {
       "color": "#87CEEB"

diff --git a/pkg-py/tests/test_typography.py b/pkg-py/tests/test_typography.py
@@ -137,7 +137,6 @@ def test_brand_typography_fields_base():
         "weight",
         "size",
         "line_height",
-        "color",
     }
 
 
@@ -601,8 +600,7 @@ def test_brand_typography_ex_color(snapshot_json):
     color = brand.color
     assert color.palette is not None
 
-    assert isinstance(t.base, BrandTypographyBase)
-    assert t.base.color == color.foreground
+    assert t.base is None  # base color is set via color.foreground
 
     assert isinstance(t.headings, BrandTypographyHeadings)
     assert t.headings.color == color.primary