-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings page #660
Closed
Closed
Add settings page #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added translation for Swedish, Dutch and Italian.
Update sv.json
Update language names
- Turkish encoding problem fix
Korean translation of en.json
Create kr.json
Fix for issue #297
When using the space bar to pause or play, it pauses then immediately resumes due to a bug in the key handler.
`e = e || event;` shouldn't be needed unless there's some webkit caveat I'm not aware of.
Changed to HEAD request since we're only checking connectivity.
Bugfix for pause/play using spacebar
"Arabic": "العربية",
Create ar.jeson
Conflicts: js/frontend/app.js
fix phrasing
translate Korean, hungrian and bulgarian into french
Remove seek handle
Fix plural in dutch legalDisclaimer translation.
Update fr.json
Update he.json
Latvian added
Js minor fixes
Updated the traditional Chinese language file.
Update hu.json
Toggle platforms to build with grunt cli option
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add a new settings page accessed by an icon on the top left corner.
This new settings page currently only have two settings:
I added a new App.settings object that manage user settings in the localstore as well. This feature was requested by many of my friends, hopefully it will be usefull to the upstream.
Preview: