Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings page #660

Closed
wants to merge 593 commits into from
Closed

Add settings page #660

wants to merge 593 commits into from

Conversation

isra17
Copy link

@isra17 isra17 commented Mar 14, 2014

This pull request add a new settings page accessed by an icon on the top left corner.
This new settings page currently only have two settings:

  • Download location: Set the movie download location (default: system temporary folder)
  • Auto clear cache: Uncheck it to prevent the removal of the video file after the movie is watched

I added a new App.settings object that manage user settings in the localstore as well. This feature was requested by many of my friends, hopefully it will be usefull to the upstream.

Preview:
image

Patineta and others added 30 commits March 8, 2014 18:39
Added translation for Swedish, Dutch and Italian.
- Turkish encoding problem fix
Korean translation of en.json
When using the space bar to pause or play, it pauses then immediately resumes due to a bug in the key handler.
`e = e || event;` shouldn't be needed unless there's some webkit caveat I'm not aware of.
Changed to HEAD request since we're only checking connectivity.
Bugfix for pause/play using spacebar
	"Arabic": "العربية",
Conflicts:
	js/frontend/app.js
@zosiu
Copy link
Contributor

zosiu commented Mar 14, 2014

👍

1 similar comment
@FGRibreau
Copy link

👍

@isra17 isra17 closed this Mar 16, 2014
@isra17 isra17 deleted the feature-settings branch April 3, 2014 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.