Fixes 2 bugs with fullscreen: #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Properly toggle active class on $('.btn-os.fullscreen') when exiting
fullscreen from the maximize button. Before this commit the button class
won't be toggled and the button would show incorrect icons.
2. Fixes a bug where it got weird and unintuitive if the user wanted to
incorrectly unmaximize the window while being in fullscreen -- while the
window was already unmaximized (but in fullscreen). Now, if the user
clicks the maximize button while being in fullscreen, it not only exits
fullscreen but also unmaximizes it.
HammamSamara
pushed a commit
to HammamSamara/popcorn-app
that referenced
this pull request
Apr 5, 2014
Translations for 0.2.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullscreen from the maximize button. Before this commit the button class
won't be toggled and the button would show incorrect icons.
incorrectly unmaximize the window while being in fullscreen -- with the
window already unmaximized (but in fullscreen). Now, if the user
clicks the maximize button while being in fullscreen, it not only exits
fullscreen but also unmaximizes it.
PS: Mi ingles apesta.. espero se entienda!