Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yifysubtitles.js #637

Closed
wants to merge 1 commit into from
Closed

Update yifysubtitles.js #637

wants to merge 1 commit into from

Conversation

SerkZex
Copy link
Contributor

@SerkZex SerkZex commented Mar 13, 2014

No description provided.

@SerkZex
Copy link
Contributor Author

SerkZex commented Mar 13, 2014

Sorry i don't know how to commit them all together :/

Update yifysubtitles.js #637
Update torrents.js #636
Update opensubtitles.js #635
Update player.js #634
Update app.css #633
Update sidebar.js #630
Update _moviedetails.scss #629

@mciparelli
Copy link

You could have asked?

git checkout -b css_js_fixes
git add 1.js
git commit -m 'patch-1'
git add 2.css
git commit -m 'patch-2'
git push -u <your-repo> css_js_fixes

send the pull request

@SerkZex
Copy link
Contributor Author

SerkZex commented Mar 13, 2014

@mciparelli were should i put that code?

and how can i send this picture to the pull?
https://github.com/HeyTech/popcorn-app3/blob/master/images/arabic.png

@mciparelli
Copy link

@heytech are you really asking me where to put six lines starting with 'git'?
I can only assume you don't know what git is even though you are writing here.
I would recommend you to close your pull requests, have it a read, then use the code I gave you and come back with one pull request that includes all your translation changes.

@SerkZex
Copy link
Contributor Author

SerkZex commented Mar 13, 2014

@mciparelli i don't need to read, i learn by mistakes and someone tells me.. reading is boring...
when i press " compare across forks." i get the last i edited in my fork and not only the picture.. how can i delete the others?
https://f.cloud.github.com/assets/6899838/2414390/013016ca-aaea-11e3-90ff-fd0bcf22422a.png

@SerkZex SerkZex closed this Mar 17, 2014
@SerkZex SerkZex deleted the patch-9 branch March 17, 2014 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants