-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate summary #502
base: master
Are you sure you want to change the base?
Translate summary #502
Conversation
From what I saw the trailers are working properly. But the trailers are displayed in English without subtitles. Unable to translate the summaries, there is a problem I'm using the "pt-br" version? |
@abadfederico believe it can still be implemented in version 3, just needs some improvements and translations. Being able to see the trailer before deciding which movie to watch brings a better experience for the user. At least I enjoyed it. |
@EvandroZanatta |
@brai4you I'll redo the sentence. Have you implemented the code to translate or provide summaries in other languages? |
yep, all languages availables in api.yandex.com |
@brai4you translation function of the synopses is now working in all languages |
@EvandroZanatta maybe it was editing something |
@brai4you I am soon going to check the code again |
or probably you downloaded the master |
ok, I will test it now |
man, this is very, very good. Just missing settling the question of the color of the button and translate it. @abadfederico @Patineta I believe that this may already be available in version 3. Translation Looks great, no errors. Gave to perfectly understand what was being said. |
Hey @brai4you ! Thanks for the contribution! Unfortunately this project is no longer being maintained, but it is being forkd by the very reputable folks at YiFy, so please resubmit your pull request to: https://github.com/Yify/popcorn-app |
Fixes popcorn-team/popcorn-app#168
suggestion of #348