Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate summary #502

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Translate summary #502

wants to merge 21 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2014

suggestion of #348

@EvandroZanatta
Copy link
Contributor

From what I saw the trailers are working properly. But the trailers are displayed in English without subtitles.

Unable to translate the summaries, there is a problem I'm using the "pt-br" version?

@EvandroZanatta
Copy link
Contributor

@abadfederico believe it can still be implemented in version 3, just needs some improvements and translations.

Being able to see the trailer before deciding which movie to watch brings a better experience for the user. At least I enjoyed it.

@ghost
Copy link
Author

ghost commented Mar 12, 2014

@EvandroZanatta
i dont have idea how to says "translate synopsis" in pt-br
If i search trailers with subtitles, it is possible false positives

@EvandroZanatta
Copy link
Contributor

@brai4you I'll redo the sentence. Have you implemented the code to translate or provide summaries in other languages​​?

@ghost
Copy link
Author

ghost commented Mar 12, 2014

yep, all languages availables in api.yandex.com
Is set depending on the language used in the system

@EvandroZanatta
Copy link
Contributor

@brai4you translation function of the synopses is now working in all languages
Yesterday I downloaded the code from your "fork" and was unable to test this function.

@ghost
Copy link
Author

ghost commented Mar 12, 2014

@EvandroZanatta maybe it was editing something

@EvandroZanatta
Copy link
Contributor

@brai4you I am soon going to check the code again

@ghost
Copy link
Author

ghost commented Mar 12, 2014

or probably you downloaded the master
try download this: https://github.com/brai4you/popcorn-app/tree/translate-summary

@EvandroZanatta
Copy link
Contributor

ok, I will test it now

@EvandroZanatta
Copy link
Contributor

man, this is very, very good. Just missing settling the question of the color of the button and translate it.

@abadfederico @Patineta I believe that this may already be available in version 3.

Translation Looks great, no errors. Gave to perfectly understand what was being said.

@davidgumberg
Copy link

Hey @brai4you ! Thanks for the contribution! Unfortunately this project is no longer being maintained, but it is being forkd by the very reputable folks at YiFy, so please resubmit your pull request to: https://github.com/Yify/popcorn-app

HammamSamara pushed a commit to HammamSamara/popcorn-app that referenced this pull request Apr 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants