Translation System, Settings Panel and more... #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes on i18n and on settings panel.
|
We need to talk about the UI :P |
|
Yes, sure. :P |
|
@gnuns Added some improvments to your PR (https://github.com/Gnuns/popcorn-app/pull/1) and it's not UI |
|
|
||
| // checks if a locale is available | ||
| i18n.isValidLocale = function i18nisValidLocale(key){ | ||
| i18n.getLocales().indexOf(key) !== -1 |
There was a problem hiding this comment.
I forgot to add a return, it could break here. @gnuns can you add it for me ?
|
👍 |
|
Hey @Patineta, have you seen this? :X |
|
Thanks for the pull request! We've scheduled the settings panel for Beta 4, and since we're releasing Beta 2.5 today (with many hotfixes) we'll wait until then to add the settings module. |
|
Ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements on i18n and on settings panel. An update of #209.
(Thanks @jeromelefeuvre)
I created a settings panel with some items requested on #150
To do:
(As you can see, i'm not a designer.)