Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier-only keybindings #187

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

PixelDoted
Copy link
Contributor

This PR adds support for modifier-only keybindings
and adds a new keybinding to open the launcher when releasing Super

any combination of modifiers should work (e.g. Super and Ctrl+Shift+alt+Super)

fixes: #5

@PixelDoted PixelDoted changed the title Added support for Modifier-only keybindings Modifier-only keybindings Sep 30, 2023
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of suggestions to prevent the whole config file getting filled with Some.

(If those don't work out for some reason, there is also implicit_some as a last resort.)

Otherwise nice work, I like the design of the Shortcut queue. 👍

src/config/key_bindings.rs Show resolved Hide resolved
src/config/types.rs Outdated Show resolved Hide resolved
@Drakulix Drakulix merged commit 4f3a682 into pop-os:master_jammy Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "super" key binding, for launcher (or other functionality)
2 participants