-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointer constraints #174
Pointer constraints #174
Conversation
d7c92bf
to
a789a4e
Compare
Updated to make use of Smithay/smithay#1137. Seems to be working fairly well now. In earlier versions I had an issue with applications that I think the |
a789a4e
to
2d0494e
Compare
Hm, looks like this introduces an issue with moving the pointer between monitors... |
2d0494e
to
dfdab66
Compare
Okay, just needed to move the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just some interactions around compositor-drawn/managed objects, where I am not certain this is a 100% correct.
I'm 100% certain that it's not correct I tested the pr for the lols, it crashes whenever the cursor interacts with compositor related objects(not always in all cases though) |
Ok figured out one reproduction case moving the pointer to the edge of the primary screen on the right side or in this case the side that doesn't have a second monitor |
@Vixea Good catch. Looks like these a possible panic in the |
dfdab66
to
de5b282
Compare
Huh, whenever clicking on windows that use pointer constraints when constrained the cursor jumps to look straight down(apps in question are games) though maybe that is a relative pointer bug... hmm. |
Hm, I had some weird behavior like that before, but it seemed to not be a problem in this PR. But I just tested OpenMW. I'll have to try some other things. |
I used Minecraft though I've found some other regressions that I think were caused by the fullscreen/maximize refractors |
I guess I was just moving around and didn't even end up clicking in my quick test... seems there's an issue in Smithay here: Smithay/smithay#1148. That wasn't happening in anvil since it's missing a call to |
de5b282
to
373af07
Compare
Depends on Smithay/smithay#872.
For some reason, pointer confinement isn't working correctly here at the moment, even though the code matches Anvil...
May need solution to Smithay/smithay#1126 for behavior to be correct.