Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cosmic-config for workspace settings #165

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Use cosmic-config for workspace settings #165

merged 1 commit into from
Oct 30, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 7, 2023

WorkspaceAmount now can be changed dynamically, which seems to basically work. We'll see how that works with WorkspaceMode and WorkspaceLayout.

If WorkspaceLayout can be changed at runtime, we'll have to update default keybindings in some way.

Drakulix
Drakulix reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on first glance.

Please don't forget to update the config.ron in the repo to not include these keys anymore.

src/shell/mod.rs Outdated Show resolved Hide resolved
src/config/mod.rs Outdated Show resolved Hide resolved
cosmic-comp-config/src/workspace.rs Outdated Show resolved Hide resolved
@ids1024 ids1024 mentioned this pull request Oct 10, 2023
Merged
18 tasks
@ids1024
Copy link
Member Author

ids1024 commented Oct 27, 2023

Updating for the latest workspaces changes, this now works pretty well, once I found a way to make sure cosmic-workspace-unstable-v1 get notified when the number of workspaces is reduced.

The only limitation to dynamic changes is that WorkspaceLayout is used for setting the default key bindings, but that is only considered on start. I think that's fine for now, and this can be changed later when the key bindings are made dynamic and moved to cosmic-config.

@ids1024 ids1024 marked this pull request as ready for review October 27, 2023 19:01
@ids1024 ids1024 requested a review from a team October 27, 2023 19:01
@ids1024 ids1024 changed the title WIP Use cosmic-config for workspace settings Use cosmic-config for workspace settings Oct 27, 2023
@ids1024
Use cosmic-config for dynamic workspace settings
81efd42 
`WorkspaceAmount`, `WorkspaceMode`, and `WorkspaceLayout` can all be
changed dynamically now.
Drakulix
Drakulix approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Drakulix Drakulix merged commit 809eeaf into master_jammy Oct 30, 2023
4 checks passed
@Drakulix Drakulix deleted the workspace-config_jammy branch November 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ids1024 @Drakulix