Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: a11y applet #703

Merged
merged 6 commits into from
Nov 4, 2024
Merged

feat: a11y applet #703

merged 6 commits into from
Nov 4, 2024

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Oct 31, 2024

No description provided.

@wash2
Copy link
Contributor Author

wash2 commented Nov 1, 2024

requires pop-os/dbus-settings-bindings#20 and pop-os/cosmic-session#80

@wash2 wash2 force-pushed the a11y branch 2 times, most recently from 4da9d1a to 8f98688 Compare November 1, 2024 12:30
@wash2 wash2 marked this pull request as ready for review November 1, 2024 14:13
@wash2 wash2 requested a review from a team November 1, 2024 14:13
@wash2 wash2 marked this pull request as draft November 1, 2024 14:14
@wash2 wash2 marked this pull request as ready for review November 1, 2024 14:19
@git-f0x
Copy link
Contributor

git-f0x commented Nov 1, 2024

Is there a reason for the bundled audio icon?

@wash2
Copy link
Contributor Author

wash2 commented Nov 1, 2024

Is there a reason for the bundled audio icon?

Nope lol

@git-f0x
Copy link
Contributor

git-f0x commented Nov 1, 2024 •
edited
Loading

Would it maybe be better to use Alignment::{Center/Start/End} instead of {Horizontal/Vertical}::{Center/Left/Right}? The former would better fit with eventual improved RTL support (and feels cleaner without having e.g. both align_x and Horizontal).

@wash2
Copy link
Contributor Author

wash2 commented Nov 1, 2024

Would it maybe be better to use Alignment::{Center/Start/End} instead of {Horizontal/Vertical}::{Center/Left/Right}? The former would better fit with eventual improved RTL support (and feels cleaner without having e.g. both align_x and Horizontal).

Maybe. I've wondered the same thing. It would have to be a PR for upstream though.

@git-f0x
Copy link
Contributor

git-f0x commented Nov 1, 2024

It's already available. I made those changes in #704.

@wash2 wash2 merged commit 22198fd into master Nov 4, 2024
10 checks passed
@wash2 wash2 deleted the a11y branch November 4, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmstick mmstick mmstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wash2 @git-f0x @mmstick