feat: audio applet over-amplification support #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justintime4tea
changed the title
justintime4tea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COSMIC system settings provide a choice between 0-150% for the volume of both output and input. The COSMIC audio applet does not.
This proposed change aligns the audio applet UI/UX with the system settings, allowing the user to "over-amplify" volume directly from the audio applet.
Updated COSMIC Audio Applet (this PR)
Existing COSMIC System Settings
This change relates to the following issues:
Considerations
Bug/Bad experience?
Without this proposed change, or one of similar impact/change, a user could set volume to 150% in COSMIC settings and afterward, when adjusting volume via the audio applet, the volume will snap-back/cap to 100 and restrict volume to between 0-100%.
Forward thinking
I understand there is a broader topic of how exactly to support "over-amplification", however, at minimum, the COSMIC audio applet should at least align with the COSMIC system settings so that whether audio is set via settings, or audio applet, the user has the same "choice" (0-150%).