Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code fix for missing assertion #60

Conversation

khatchad
Copy link
Member

@khatchad khatchad commented Nov 30, 2023

Fixes wala#109.

@khatchad khatchad self-assigned this Nov 30, 2023
@khatchad khatchad added the bug Something isn't working label Nov 30, 2023
@khatchad khatchad changed the title Test code fix for https://github.com/wala/ML/issues/109. Test code fix for missing assertion. Dec 1, 2023
@khatchad khatchad changed the title Test code fix for missing assertion. Test code fix for missing assertion Dec 1, 2023
Looks like these were wrong since we weren't checking them. I verified in the IR that indeed v3 refers to the parameter.
@khatchad khatchad marked this pull request as ready for review December 1, 2023 19:15
@khatchad khatchad merged commit aecbe50 into master Dec 1, 2023
3 checks passed
@khatchad khatchad deleted the 109-not-checking-actual-value-numbers-for-tensor-parameters-in-tf2-tests branch December 1, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not checking actual value numbers for tensor parameters in TF2 tests
1 participant