Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this branch #287

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Update this branch #287

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da43c6c
Add TODO.
khatchad Nov 9, 2023
91ba7d9
Remove TODOs for #120.
khatchad Nov 10, 2023
2f49d0c
Don't stop checking if side-effects can't be determined.
khatchad Nov 10, 2023
b38e2a0
Merge branch '120-add-a-failure-refactoring-status-entry-upon-ambiguo…
khatchad Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...rc/edu/cuny/hunter/hybridize/core/refactorings/HybridizeFunctionRefactoringProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,6 @@ private RefactoringStatus checkFunctions(IProgressMonitor monitor) throws Operat
LOG.warn("Unable to infer side-effects of: " + func + ".", e);
func.addFailure(PreconditionFailure.UNDETERMINABLE_SIDE_EFFECTS,
"Can't infer side-effects, most likely due to a call graph issue caused by a decorator or a missing function call.");
// next function. FIXME: Why not continue?
status.merge(func.getStatus());
subMonitor.worked(1);
return;
}

// check the function preconditions.
Expand Down