Code

Check for Python side-effects#269

Code

Merged

khatchad merged 175 commits intomainponder-lab/Hybridize-Functions-Refactoring:mainfrom side_effectsponder-lab/Hybridize-Functions-Refactoring:side_effectsCopy head branch name to clipboardNov 9, 2023

+2,617-95

Commits

Commits on Oct 13, 2023

• Add Python side-effects test.

  khatchad

  committed
  0672e7b

Commits on Oct 16, 2023

• More tests for side-effects.

  khatchad

  committed
  89f55a8

• Add list manipulation test.

  khatchad

  committed
  8790bfc

• Progress.

  khatchad

  committed
  2787b11

• Fix progress monitors.

  khatchad

  committed
  4e38b13

• Fix logs.

  khatchad

  committed
  399bb7c

Commits on Oct 17, 2023

• Fix checkstyle warning.

  khatchad

  committed
  a5c029b

• Fix exception message.

  khatchad

  committed
  6a85b87

• Merge branch 'side_effects' of https://github.com/ponder-lab/Hybridize-Functions-Refactoring into side_effects

  khatchad

  committed
  7255d4d

• Adjust indentation.

  khatchad

  committed
  23fc5ab

• Fix spelling.

  khatchad

  committed
  8a8ea13

• Progress.

  khatchad

  committed
  3d2dd87

• Progress.

  khatchad

  committed
  8714c34

• Add (Python) side-effects to CSVs.

  khatchad

  committed
  889fdd7

• Progress.

  khatchad

  committed
  e5af9aa

Commits on Oct 18, 2023

• Remove unused import.

  khatchad

  committed
  99272cb

• Suppress warning.

  khatchad

  committed
  081b132

• Change field name.

  khatchad

  committed
  25f766a

• Fix compilation error.

  khatchad

  committed
  c676527

• Add transitive test.

  khatchad

  committed
  18ebc57

• Not having a switch default is OK.

  khatchad

  committed
  3c57a76

• Add doc.

  khatchad

  committed
  a78e995

• Make static.

  khatchad

  committed
  99b3d6b

• Remove unused import.

  khatchad

  committed
  0c1f532

• Add doc.

  khatchad

  committed
  460aa31

• Add helper method.

  khatchad

  committed
  75ff03a

• Fix doc.

  khatchad

  committed
  757094c

• Add helper methods.

  khatchad

  committed
  40cf6a9

• Test transitive side-effects in different files.

  khatchad

  committed
  bc31996

• Revert "Not having a switch default is OK."

  Show description for e3cb664
  khatchad

  committed
  e3cb664

• Squelch warning about missing default case.

  khatchad

  committed
  175b7a6

• Make methods static.

  khatchad

  committed
  19467d9

• Fix warning.

  khatchad

  committed
  fc40482

• Add extra checks.

  khatchad

  committed
  8c871c1

• Add side-effects checks to model tests.

  Show description for e24a5e4
  khatchad

  committed
  e24a5e4

• Fix comment.

  khatchad

  committed
  7bc23b0

• Update comment.

  khatchad

  committed
  1800dbf

• Add a model test with Python side-effects.

  khatchad

  committed
  dd5d366

• Fix javadoc comment.

  khatchad

  committed
  8a3cdc8

Commits on Oct 19, 2023

• Simplify test.

  khatchad

  committed
  6ebbad6

• Use our own ModRef.

  khatchad

  committed
  05261e7

• Simplify test.

  khatchad

  committed
  675aa04

• Use built-in function.

  Show description for cbff639
  khatchad

  committed
  cbff639

Commits on Oct 20, 2023

• Remove unnecessarily cast.

  khatchad

  committed
  fe85106

• Handle side-effects from print().

  khatchad

  committed
  ea95aa6

• We don't need tensorflow for this test.

  khatchad

  committed
  6de1905

• Add write() tests.

  khatchad

  committed
  1e67820

• Update to ML 0.10.0-SNAPSHOT.

  khatchad

  committed
  1e6e6d4

• Require at least ML 0.9.0 for call graphs.

  khatchad

  committed
  2f0352e

Commits on Oct 23, 2023

• Fix method name.

  khatchad

  committed
  878a9c5

• Filter out metaprogramming locations.

  khatchad

  committed
  5c599fd

• Fix errors.

  khatchad

  committed
  d8774cb

Commits on Oct 24, 2023

• Don't print so much.

  khatchad

  committed
  9077d4e

• Use defaults.

  khatchad

  committed
  3793d63

• Enable assertions for our project.

  khatchad

  committed
  2eba547

• Add sanity check for side-effects.

  Show description for dc632e3
  khatchad

  committed
  dc632e3

• Use custom exception.

  khatchad

  committed
  f57432b

• Use precomputed symbolic bundle name.

  khatchad

  committed
  15b0afd

• Remove unused import.

  khatchad

  committed
  c09728d

• Format.

  khatchad

  committed
  1fa5be9

• Shorten log.

  khatchad

  committed
  bc017a0

• Remove unused import.

  khatchad

  committed
  0b0a0e7

• Additional filtering.

  khatchad

  committed
  eb3f921

• Log removed locations.

  khatchad

  committed
  14c2424

• Only set side-effects once.

  khatchad

  committed
  97e75a5

• Change method name.

  khatchad

  committed
  9f983b9

• Fix side-effects.

  khatchad

  committed
  d42f263

• Add log.

  khatchad

  committed
  7225a23

• Cleanup test file.

  khatchad

  committed
  5cd363a

• Remove unused imports.

  khatchad

  committed
  48dfe80

• List comprehensions aren't working.

  khatchad

  committed
  ef83ecb

Commits on Oct 25, 2023

• Fix list comphrensions.

  khatchad

  committed
  3173961

• Simplify boolean.

  khatchad

  committed
  dfbf202

• Switch expressions.

  Show description for 53e7011
  khatchad

  committed
  53e7011

• Additional side-effects tests.

  khatchad

  committed
  aabbd84

• Add system property to dump call graphs.

  khatchad

  committed
  9fa43c1

• Add assertions.

  khatchad

  committed
  73a9c16

• Suppress fall-through warning.

  khatchad

  committed
  a093c2e

• Tests for transitive side-effects.

  khatchad

  committed
  31e7ecf

Commits on Oct 26, 2023

• Add transitive list comphrension tests.

  khatchad

  committed
  83fce2c

• Fix assertion messages.

  khatchad

  committed
  eff997c

• More tests.

  khatchad

  committed
  f7feee1

• Cleanup test file.

  khatchad

  committed
  359ae14

• Add comments.

  khatchad

  committed
  da6c3aa

• Use helper method.

  khatchad

  committed
  66d5d23

• Consider list.append as having side-effects.

  khatchad

  committed
  5987632

• Remove unused import.

  khatchad

  committed
  cbe0381

• Handle local pointer keys.

  khatchad

  committed
  bca5bb9

• Revert "Cleanup test file."

  Show description for 752eb39
  khatchad

  committed
  752eb39

• Revert "Revert "Cleanup test file.""

  Show description for 93b101f
  khatchad

  committed
  93b101f

• Work around #274.

  khatchad

  committed
  9623754

• Add parameter test case.

  khatchad

  committed
  26af352

• Should suffice.

  khatchad

  committed
  1e85172

• Be more defensive.

  Show description for b63e2ca
  khatchad

  committed
  b63e2ca

• Make API more consistent wih WALA.

  khatchad

  committed
  0948eca

• Remove else clause.

  khatchad

  committed
  13a9022

• Progress.

  khatchad

  committed
  0b9f25a

Commits on Oct 27, 2023

• More global keyword testing.

  khatchad

  committed
  ac85cec

• If thera are no creations, then I guess they're not in the function.

  khatchad

  committed
  e2e2735

• Fix comment.

  khatchad

  committed
  4e82566

• Handle globals.

  khatchad

  committed
  6bba964

• Add FIXMEs.

  khatchad

  committed
  e84a3e3

• Fix globals.

  khatchad

  committed
  57e9cfb

• Handle empty points-to set case.

  khatchad

  committed
  05a0af1

Commits on Oct 30, 2023

• Upgrade to Ariadne 0.11.0-SNAPSHOT.

  Show description for b446460
  khatchad

  committed
  b446460

• Shorten method name.

  khatchad

  committed
  ceb822a

• Fix exception handling.

  khatchad

  committed
  15daf3a

• Use this.`

  khatchad

  committed
  e052879

• Cleanup.

  khatchad

  committed
  2b34b29

Commits on Oct 31, 2023

• Add Eclipse version to CONTRIBUTING.md.

  Show description for 5913774
  khatchad

  committed
  5913774

• Eclipse metadata updates.

  khatchad

  committed
  9ceca36

• Use PLUGIN_ID.

  khatchad

  committed
  fc7824c

• Additional parameter tests.

  khatchad

  committed
  b5251cc

• Add side-effect test from docs.

  khatchad

  committed
  b53b425

• More side-effect testing from docs.

  khatchad

  committed
  dc7d59c

• Add model side-effect tests.

  khatchad

  committed
  e604cdc

• Add TODO.

  khatchad

  committed
  98e54d8

Commits on Nov 1, 2023

• More side-effects tests from the docs.

  khatchad

  committed
  2e3f4f6

• Add tests for "All outputs of a tf.function must be return values."

  Show description for 687802e
  khatchad

  committed
  687802e

Commits on Nov 2, 2023

• Add leaky test.

  khatchad

  committed
  a866ed4

• Add leaky test failure cases.

  khatchad

  committed
  a996a66

• Progress on testing.

  Show description for 230f276
  khatchad

  committed
  230f276

• Add captured leaked tensor case.

  Show description for eae5ac4
  khatchad

  committed
  eae5ac4

• Add eager case for #281.

  khatchad

  committed
  699177b

• Add missing period.

  khatchad

  committed
  7c12e21

• Add another leaky test.

  khatchad

  committed
  98c40e3

• Multiple errors on this test.

  khatchad

  committed
  e4264ca

• More tests.

  Show description for 3c34208
  khatchad

  committed
  3c34208

• Fail the test.

  khatchad

  committed
  cdc66c4

• If there are no side-effects, then it could pass.

  khatchad

  committed
  fae4c96

• Add TODOs.

  khatchad

  committed
  c9459d9

Commits on Nov 3, 2023

• Progress.

  khatchad

  committed
  f4dad0b

• Add count failures only once sanity check.

  khatchad

  committed
  851e773

• Test code fixes.

  khatchad

  committed
  5099386

• More test fixes.

  khatchad

  committed
  762ca93

• Fix test.

  khatchad

  committed
  34580b6

• Fix tests.

  khatchad

  committed
  33ae3d7

• Remove unused precondition failures.

  khatchad

  committed
  ef6863e

• Get statistics only on candidates.

  khatchad

  committed
  2cc58fc

• Add severity level to failures.

  Show description for 62cbf48
  khatchad

  committed
  62cbf48

• Print all statuses.

  khatchad

  committed
  7d1aa12

• Add TODOs.

  khatchad

  committed
  f4087d1

Commits on Nov 6, 2023

• Don't revisit recursive calls.

  khatchad

  committed
  1d7013d

• Add refactoring kind to status outut.

  Show description for 0f68c16
  khatchad

  committed
  0f68c16

• Shorten warning message.

  khatchad

  committed
  af1aa3d

• Use function.

  khatchad

  committed
  7a4ad0e

• Change else block to statement.

  khatchad

  committed
  cf21780

• Fix candidate detection.

  Show description for b3df810
  khatchad

  committed
  b3df810

• Fix warning about hybrid functions with side-effects.

  khatchad

  committed
  97e6a2f

• Fix candidate bug.

  khatchad

  committed
  ccc8c03

• Organize imports.

  khatchad

  committed
  9737e68

• Only output nodes in verbose mode.

  khatchad

  committed
  f711d94

• Update comment.

  khatchad

  committed
  df04cad

• Organize imports.

  khatchad

  committed
  8306682

• Use only one call graph node per function declaration.

  khatchad

  committed
  36f7315

• Fix warning.

  Show description for efd7ce4
  khatchad

  committed
  efd7ce4

• Fix test.

  khatchad

  committed
  dd7a6d7

• Use accessor.

  khatchad

  committed
  482329a

Commits on Nov 7, 2023

• Add caching to Python side-effects.

  Show description for e890d11
  khatchad

  committed
  e890d11

• Analyze functions in parallel.

  khatchad

  committed
  a54f674

• Update comment.

  khatchad

  committed
  5bcc963

• Conditionally check Python side-effects.

  Show description for c54341a
  khatchad

  committed
  c54341a

• Use static import.

  khatchad

  committed
  c7033b1

• Add side-effect test that uses keyword arguments.

  khatchad

  committed
  dd65812

• Get the fix for wala/ML#103.

  khatchad

  committed
  8b9b346

Commits on Nov 8, 2023

• Add embedded function test.

  khatchad

  committed
  438007e

• Optimizable functions should be taken from candidates.

  khatchad

  committed
  fa50a56

• Optimizable functions should be taken from candidates.

  khatchad

  committed
  9369958

• Add decorated test.

  khatchad

  committed
  48d7581

• Add option to always check Python side-effects for the evaluator.

  khatchad

  committed
  c4ab93b

• Look for a specific function.

  khatchad

  committed
  68b2225

Commits on Nov 9, 2023

• Revert "Look for a specific function."

  Show description for 9075f4e
  khatchad

  committed
  9075f4e

• Merge branch 'issue_284' into side_effects

  khatchad

  committed
  617041b

• Run tests sequentially.

  Show description for 12a721e
  khatchad

  committed
  12a721e

• Merge branch 'main' into side_effects

  khatchad

  authored
  a587d2b