Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create evaluation plug-in #263

Merged
merged 51 commits into from
Oct 6, 2023
Merged

Create evaluation plug-in #263

merged 51 commits into from
Oct 6, 2023

Conversation

khatchad
Copy link
Member

@khatchad khatchad commented Oct 6, 2023

Fixes #31. Puts some parsing code in Core Utilities so that both UI and evaluation plug-ins can access it.

Commits

  • I slowed down and took a deep breadth before committing. Otherwise, I will start a pristine branch and reissue this pull request.
  • Before committing my changes, I checked my working directory carefully. I only staged the changes I wanted and ensured it was of the utmost quality.
  • I used git diff and git status to check my work carefully before committing.
  • I completely understand what I am committing and why.
  • I completely understand why things are the way they are.
  • The change I am proposing makes complete sense to me.
  • For the most part, the changes in this pull request correspond to the problem or task I am solving or performing. In other words, only the changes that are supposed to be there are the ones included in this pull request.

Expectations

The plug-in can now be evaluated.

Testing

Six CSVs created with the correct headings and values.

Final Checks

  • The changes I am proposing meet the expectations I have described above.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation if applicable.
  • I have added tests that prove my fix is effective or that my feature works if applicable.
  • New and existing unit tests pass locally with my changes.

@khatchad khatchad enabled auto-merge October 6, 2023 18:40
@khatchad khatchad disabled auto-merge October 6, 2023 18:43
@khatchad khatchad enabled auto-merge October 6, 2023 18:47
@khatchad khatchad mentioned this pull request Oct 6, 2023
@khatchad khatchad disabled auto-merge October 6, 2023 19:01
@khatchad khatchad merged commit 15fc4a6 into main Oct 6, 2023
4 checks passed
@khatchad khatchad deleted the 31-create-evaluation-plug-in2 branch October 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create evaluation plug-in
1 participant