Skip to content

Commit

Permalink
Don't stop checking if side-effects can't be determined.
Browse files Browse the repository at this point in the history
  • Loading branch information
khatchad committed Nov 10, 2023
1 parent 91ba7d9 commit 2f49d0c
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@ private RefactoringStatus checkFunctions(IProgressMonitor monitor) throws Operat
LOG.warn("Unable to infer side-effects of: " + func + ".", e);
func.addFailure(PreconditionFailure.UNDETERMINABLE_SIDE_EFFECTS,
"Can't infer side-effects, most likely due to a call graph issue caused by a decorator or a missing function call.");
// next function. FIXME: Why not continue?
status.merge(func.getStatus());
subMonitor.worked(1);
return;
}

// check the function preconditions.
Expand Down

0 comments on commit 2f49d0c

Please sign in to comment.